Skip to content

Commit

Permalink
Fix dependency on lwt.unix
Browse files Browse the repository at this point in the history
Module Markup_lwt_unix depends on Findlib packages lwt and lwt.unix.
However, the only dependency actually listed in _tags was on package
lwt. Until recently, Lwt installed all files in a flat directory.
Depending on package lwt causes ocamlfind to add a -I option for that
directory; since the directory was flat, that option was sufficient to
be able to accidentally find the files of lwt.unix as well.

Lwt now installs files in a directory hierarchy. In particular, lwt.unix
is now installed in a separate subdirectory. The -I option implied by
depending on package lwt is therefore no longer accidentally sufficient
for using lwt.unix, and this causes an error during compilation of
Markup.ml if Lwt is present.

So, this commit does the right thing, and adds the proper, explicit
dependency on lwt.unix.

This bug was originally found in Markup.ml, as well as several other
packages, by @andrewray during ocsigen/lwt#374.

Fixes #18.
See also ocsigen/lwt#401.
  • Loading branch information
aantron committed Jun 13, 2017
1 parent 0bf4f1b commit 7de22ab
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions _tags
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

<src/*> or <test/**>: package(uutf)
<src/markup_lwt*>: package(lwt)
<src/markup_lwt_unix*>: package(lwt.unix)

<src/translate_entities.*>: package(yojson)

Expand Down

0 comments on commit 7de22ab

Please sign in to comment.