Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency on lwt.unix and release to OPAM #18

Closed
aantron opened this issue Jun 13, 2017 · 1 comment
Closed

Fix dependency on lwt.unix and release to OPAM #18

aantron opened this issue Jun 13, 2017 · 1 comment

Comments

@aantron
Copy link
Owner

aantron commented Jun 13, 2017

Markup.ml is not compatible with Lwt master, because it does not depend correctly on lwt.unix. cc @bluddy. See ocsigen/lwt#401 and ocsigen/lwt#374.

@aantron
Copy link
Owner Author

aantron commented Jun 14, 2017

The diagnostics looked like this:

# + ocamlfind ocamlc -c -g -w +A-4-9-44-45-48 -warn-error +A-3 -bin-annot -safe-string -package lwt -package uutf -I src -I test -I doc -I test/performance -I test/pages -I test/js_of_ocaml -I test/dependency -o src/markup_lwt_unix.cmi src/markup_lwt_unix.mli
# File "src/markup_lwt_unix.mli", line 20, characters 14-41:
# Error: Unbound module Lwt_io
# Command exited with code 2.

I've also added a note to myself to mark existing Markup releases in OPAM as conflicting with Lwt >= 3.1.0, once that is nearing release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant