-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Gho steward v2 #388
Feat: Gho steward v2 #388
Conversation
This pull request has been linked to 1 task:
|
Link T-19001 |
src/contracts/facilitators/aave/interestStrategy/FixedRateStrategyFactory.sol
Show resolved
Hide resolved
src/contracts/facilitators/aave/interestStrategy/FixedRateStrategyFactory.sol
Outdated
Show resolved
Hide resolved
src/contracts/facilitators/aave/interestStrategy/interfaces/IFixedRateStrategyFactory.sol
Outdated
Show resolved
Hide resolved
src/contracts/facilitators/aave/interestStrategy/interfaces/IFixedRateStrategyFactory.sol
Outdated
Show resolved
Hide resolved
src/contracts/facilitators/aave/interestStrategy/interfaces/IFixedRateStrategyFactory.sol
Outdated
Show resolved
Hide resolved
src/contracts/facilitators/aave/interestStrategy/interfaces/IFixedRateStrategyFactory.sol
Outdated
Show resolved
Hide resolved
src/contracts/facilitators/aave/interestStrategy/interfaces/IFixedRateStrategyFactory.sol
Outdated
Show resolved
Hide resolved
src/contracts/facilitators/aave/interestStrategy/interfaces/IFixedRateStrategyFactory.sol
Outdated
Show resolved
Hide resolved
src/contracts/facilitators/aave/interestStrategy/interfaces/IFixedRateStrategyFactory.sol
Outdated
Show resolved
Hide resolved
src/contracts/facilitators/aave/interestStrategy/interfaces/IFixedRateStrategyFactory.sol
Outdated
Show resolved
Hide resolved
src/contracts/facilitators/aave/interestStrategy/interfaces/IFixedRateStrategyFactory.sol
Outdated
Show resolved
Hide resolved
Thanks for the review @sakulstra . All changes are applied now. |
as the market conditions changed quite a lot governance is requesting a change in stewards params : https://governance.aave.com/t/arfc-gho-stewards-borrow-rate-update/16956 here's the detail:
we suggest implementing these changes and then sync enforcement with vote result |
src/contracts/misc/GhoStewardV2.sol
Outdated
using ReserveConfiguration for DataTypes.ReserveConfigurationMap; | ||
|
||
/// @inheritdoc IGhoStewardV2 | ||
uint256 public constant GHO_BORROW_RATE_MAX = 0.0950e27; // 9.50% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uint256 public constant GHO_BORROW_RATE_MAX = 0.0950e27; // 9.50% | |
uint256 public constant GHO_BORROW_RATE_MAX = 0.2500e27; // 25.00% |
src/contracts/misc/GhoStewardV2.sol
Outdated
uint256 public constant GHO_BORROW_RATE_MAX = 0.0950e27; // 9.50% | ||
|
||
/// @inheritdoc IGhoStewardV2 | ||
uint256 public constant GHO_BORROW_RATE_CHANGE_MAX = 0.0050e27; // 0.50% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uint256 public constant GHO_BORROW_RATE_CHANGE_MAX = 0.0050e27; // 0.50% | |
uint256 public constant GHO_BORROW_RATE_CHANGE_MAX = 0.0500e27; // 5.0% |
src/contracts/misc/GhoStewardV2.sol
Outdated
uint256 public constant GSM_FEE_RATE_CHANGE_MAX = 0.0050e4; // 0.50% | ||
|
||
/// @inheritdoc IGhoStewardV2 | ||
uint256 public constant MINIMUM_DELAY = 7 days; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uint256 public constant MINIMUM_DELAY = 7 days; | |
uint256 public constant MINIMUM_DELAY = 2 days; |
Changes applied per gov thread discussion |
Usage
Allows approved risk provider to change GHO and GSM parameters.
Steps from governance to work as intended
These roles must be assigned by DAO:
PoolAdmin
in the Aave V3 Ethereum PoolBucketManager
in GHO TokenConfigurator
in every GSM asset that the DAO wants the risk council to manageOwner of the contract (DAO) needs to add each facilitator (GHO AToken/GSM) to a controlled list in
GhoStewardV2
, withsetControlledFacilitator
methodFixedRateStrategyFactory must be deployed before deploying the Stewards contract, as its used for creating fixed rate strategies for updating the GHO borrow rate.
Limitations on calls and/or parameters:
General:
Facilitators:
updateFacilitatorBucketCapacity
:GHO:
updateGhoBorrowCap
:updateGhoBorrowRate
:GSM:
updateGsmExposureCap
:updateGsmFeeStrategy
:Management:
controlFacilitator
:Considerations:
setControlledFacilitator
withfalse
if they want to disable it for certain GSMs