Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Gho steward v2 #388
Feat: Gho steward v2 #388
Changes from 12 commits
6763340
45361a1
426e39c
7dc49c4
1f23190
1373dae
7000996
54ecaff
7c40a3a
ba70de3
e40f895
d548248
28face8
79829a5
45c7dc5
c160ced
6fe257b
9b4e8cb
e2b3e4b
7f42dfc
967025c
7d33cbb
c23dd42
2de50ff
4f67e2e
1962c0e
1e9e2c9
dfabf24
32f4ff2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as i understand there's nothing really "GHO" specific about this ir. It's just a constant ir. Wouldn't it make more sense to externalize the ir registry/factory in a similar pattern as https://github.com/bgd-labs/aave-helpers/blob/master/src/v3-config-engine/V3RateStrategyFactory.sol ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
GhoInterestRateStrategy
offers a constant borrow rate. While theDefaultReserveInterestRateStrategy
could also provide a constant rate, it adds unnecessary complexity in a less efficient way. We also prefer to keep this implementation as it is, to speed up the its deployment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point was not about using
DefaultReserveInterestRateStrategy
but using a factory/registry that is detached from the GhoSteward. AConstantInterestStrategyFactory
of sorts.This way it would be:
The config engine has been upgraded 3 or 4 times by now and risk steward also has a pending v2.
As the IR-factory was externalized, there has never been an update needed for this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the implementation with a new contract FixedRateStrategyFactory which is a simplified version of the one you shared, using GhoInterestRateStrategy. I've used
Fixed
instead ofConstant
because i think it't more consistent with how we name in this repo.Let me know what you think about this.