Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dereference issue on ARTOSReachability #1452

Closed
wants to merge 12 commits into from
Closed

Fix dereference issue on ARTOSReachability #1452

wants to merge 12 commits into from

Conversation

ikbalkaya
Copy link
Contributor

@ikbalkaya ikbalkaya commented Jul 28, 2022 •
edited
Loading

This PR follows this blog post to potentially fix for #593 and #1380

@ikbalkaya ikbalkaya added the bug Something isn't working. It's clear that this does need to be fixed. label Jul 28, 2022
@github-actions github-actions bot temporarily deployed to staging/pull/1452/jazzydoc July 28, 2022 11:28 Inactive
@ikbalkaya ikbalkaya changed the title Dereference issue Fix dereference issue in ARTOSReachability Jul 28, 2022
@ikbalkaya ikbalkaya changed the title Fix dereference issue in ARTOSReachability Fix dereference issue on ARTOSReachability Jul 28, 2022
@ikbalkaya ikbalkaya requested a review from maratal July 28, 2022 11:45
@ikbalkaya ikbalkaya marked this pull request as ready for review July 28, 2022 13:41
@github-actions github-actions bot temporarily deployed to staging/pull/1452/jazzydoc July 28, 2022 14:23 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1452/jazzydoc July 28, 2022 16:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1452/jazzydoc July 29, 2022 08:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1452/jazzydoc July 29, 2022 08:59 Inactive
@maratal
Copy link
Collaborator

maratal commented Jul 29, 2022

I'm closing this PR, changes in ARTOSReachability requires more deep investigation @ikbalkaya

@maratal maratal closed this Jul 29, 2022
@maratal
Copy link
Collaborator

maratal commented Jul 30, 2022

New PR #1453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakubJankowski JakubJankowski JakubJankowski approved these changes

@maratal maratal Awaiting requested review from maratal

@owenpearson owenpearson Awaiting requested review from owenpearson

@Peter-Maguire Peter-Maguire Awaiting requested review from Peter-Maguire

Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikbalkaya @maratal @JakubJankowski