Fix of the crash in the ARTOSReachability
#1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one. This is actual cause of crash due to ghost `SCNetworkReachabilityRef` instance in memory after it was overwritten without `release` during reconnections attempts. In case when `ARTRealtimeInternal` is deallocated (for example when a new `ARTRealtime` object created), those ghost instances begin to refer to a dead `ARTOSReachability` instances in the `SCNetworkReachabilityContext` structure.
We pass `_queue` already, why run loop was even used?
…oop." This reverts commit 83fb813.
stmoreau
approved these changes
Aug 1, 2022
maratal
pushed a commit
that referenced
this pull request
Jul 19, 2023
…dd-to-IDL [EDX-175] Document the stats types and add to the IDL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1380 and probably #593