-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use temporary node-fetch fork #3
fix: use temporary node-fetch fork #3
Conversation
d4943fa
to
6ed1d88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@achingbrain could you please have a look ?
I think this module should depend on
The latest version of the fork is Alternatively, it looks like the problem you are trying to solve is that stackblitz/codesandbox don't support the
TBH I don't know if stackblitz/codesandbox support that format either but this repo feels like the wrong place to fix this problem. Longer term we'll probably swap out It requires node 16 though, so it'll have to wait until node 16 becomes LTS, which is six weeks or so away. |
6ed1d88
to
7f529a6
Compare
Thanks for the suggestion, I've already updated the I ran the commands:
This PR is optional, just adds types to the project. Changes made on |
7f529a6
to
ae813ec
Compare
ae813ec
to
f294ae4
Compare
This module now uses undici and not |
This change is needed to run the examples in the web sandboxes (like codesandbox and stackblitz) because ipfs depends on js-ipfs-utils and this one depends on node-fetch.
When testing the examples using the stackblitz it throws an error:
Unable to resolve package (node-fetch npm:@achingbrain/node-fetch@^2.6.4) Please try installing a different version or range.
This resolution is being address in the js-ipfs-utils (see: ipfs/js-ipfs-utils#136)
CC: @achingbrain @hugomrdias