-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change dependency override #136
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
This is blocked until Node v16 becomes LTS (~2021-10-26 according https://nodejs.org/en/about/releases/). |
@lidel can you explain why ? if achingbrain/native-fetch#3 gets merged it should be ok |
21c7e70
to
fc75db1
Compare
src/http.js
Outdated
@@ -137,6 +137,7 @@ class HTTP { | |||
} | |||
), | |||
opts.timeout, | |||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment of the PR, the CI was failing due to some types.
> aegir build --no-bundle
[11:21:13] Clean ./dist [started]
[11:21:13] Clean ./dist [completed]
[11:21:13] Generate types [started]
src/http.js(140,7): error TS2345: Argument of type 'AbortController | AbortController' is not assignable to parameter of type 'AbortController'.
Type 'import("/home/runner/work/js-ipfs-utils/js-ipfs-utils/node_modules/abort-controller/dist/abort-controller").default' is not assignable to type 'AbortController'.
Types of property 'signal' are incompatible.
Property 'abort' is missing in type 'import("/home/runner/work/js-ipfs-utils/js-ipfs-utils/node_modules/abort-controller/dist/abort-controller").AbortSignal' but required in type 'AbortSignal'.
[11:21:16] Generate types [failed]
[11:21:16] → Command failed with exit code 1: tsc --build /home/runner/work/js-ipfs-utils/js-ipfs-utils/tsconfig-types.aegir.json
Command failed with exit code 1: tsc --build /home/runner/work/js-ipfs-utils/js-ipfs-utils/tsconfig-types.aegir.json
This was a quick and dirty solution to fix in order to test in codesandbox but without success. I was targeting this PR instead and the sandbox did not like it either.
Note that this change breaks environments where the npmjs registry is not available (such as corporate proxied networks). Even if a custom registry is configured, npm will try to download the dependency from npmjs. |
This change is needed to run the examples in the web sandboxes (like codesandbox and stackblitz)
When testing the examples using the stackblitz it throws an error:
Unable to resolve package (node-fetch npm:@achingbrain/node-fetch@^2.6.4) Please try installing a different version or range.
CC: @achingbrain @hugomrdias