Disable GC for acton pkg upgrade #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TLS lib doesn't interoperate well with our GC. While tlsuv does allow custom mallocs, there is an asymmetry for where malloc / free is done for DNS addrinfo structs. We control the malloc side and point to GC_malloc while on the free side, a normal free() is used. That leads to crashes, so if the GC runs at the wrong time, we'll crash. Since pkg upgrade is a very small and simple operation, memory usage is negligible and thus we can live without GC. It's ugly, but at least pkg upgrade works. Clearly the solution is to fix the DNS resolution. We already have this working for TCPConnection, so should port that to TLSConnection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TLS lib doesn't interoperate well with our GC. While tlsuv does allow custom mallocs, there is an asymmetry for where malloc / free is done for DNS addrinfo structs. We control the malloc side and point to GC_malloc while on the free side, a normal free() is used. That leads to crashes, so if the GC runs at the wrong time, we'll crash.
Since pkg upgrade is a very small and simple operation, memory usage is negligible and thus we can live without GC. It's ugly, but at least pkg upgrade works.
Clearly the solution is to fix the DNS resolution. We already have this working for TCPConnection, so should port that to TLSConnection.