Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GC for acton pkg upgrade #2166

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Disable GC for acton pkg upgrade #2166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cli/src/acton.act
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import acton.rts
import argparse
import file
import json
Expand Down Expand Up @@ -1033,6 +1034,14 @@ actor CmdPkgUpgrade(env, args):

zig = file.join_path([base_path(file.FileCap(env.cap)), "zig", "zig"])

# GAAH, the TLS lib does DNS lookups which interferes with GC as the malloc
# / free is asymmetric, we malloc (using GC malloc) while the free happens
# deeper inside and then incorrectly tries to free a GC malloced chunk
# We should replace with our own DNS lookups, but until then, disable GC for
# pkg upgrade. Should not be a practical problem to run without GC.
# TODO: remove this!!!!
acton.rts.disable_gc(env.syscap)

# What arguments do we need?
# - the name of the dependency (e.g. "foo", used in the build.act.json config file)
# - the URL to fetch it from
Expand Down
Loading