Compatibility for NEC protocol is fixed #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #40, #39, #65 and enhance one.
First of all, the IR protocol used primarily in the world is the NEC protocol. The code in this repository was also inferred to assume the NEC protocol from the code comments.
#40 is a sample issue, so I have adapted to the NEC protocol.
#39 may also be a sample issue, I added the value instead of 0 because the NEC protocol requires an trail.
examples/irremote_transmit.py
At the same time, decoding was adapted to the NEC protocol. This is a destructive change, but if this is not done, the RX/TX will not be consistent.
adafruit_irremote.py
#65 is simply a typing change.
adafruit_irremote.py
And the following is enhancement. The header is now variable instead of 2 fixed. This is useful for protocols that require a leader mark in addition to the header (e.g., Hitachi remote controls).
adafruit_irremote.py
Please review and merge.
Because of the disruptive changes, a major version update would be desirable.