IR learning guides have ones and zeros swapped #2813
Conversation
the list values for ONE and ZERO are swapped from what is described in the Adafruit_irremote.py library. This error causes the receiver to get the one-s compliment of the expected data.
the list values for ONE and ZERO are swapped from what is described in the Adafruit_irremote.py library. This error causes the receiver to get the one-s compliment of the expected data.
the list values for ONE and ZERO are swapped from what is described in the Adafruit_irremote.py library. This error causes the receiver to get the one-s compliment of the expected data.
the list values for ONE and ZERO are swapped from what is described in the Adafruit_irremote.py library. This error causes the receiver to get the one-s compliment of the expected data.
Correct CircuitPython IR ?learning guides to match irremote library example
There was a problem hiding this comment.
This looks good. It essentially completes the corrections done by @tkomde in adafruit/Adafruit_CircuitPython_IRRemote#68 and adafruit/Adafruit_CircuitPython_IRRemote#69.
I'll review the guides text and change as needed.
There was a problem hiding this comment.
Some discord discussion: the library uses 560 instead of 550 and its header values are [9000, 4500]. @bradanlane will retest.
|
As suggested by @dhalbert, the IR Transmit learning examples have been updated to use header pulses of 9000,4500 and a mark pulse of 560. Testing was done using the Raspberry Pi PICO with the Adafruit IR emitter and IR Receiver modules. Testing on Circuit Plaground Express was not conducted as I do not have hardware. |
|
embarrassing copy/paste error |
There are several CircuitPython learning guides related to IR. When tested them, they produced "2's compliment" results. I discovered the transmit examples had reversed the values for a "0" vs a "1".
To verify, my observation, I reviewed the sample code from the irremote CircuitPython library. The library code has the correct values for "0" and "1".
This pull request makes that corrections for the learning guides.
The learning guide changes were run on a Raspberry Pi PICO with the Adafuit IR Emitter module and the IR Receiver module