Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should allow autofocus to be disabled. #813

Closed
mikepc opened this issue May 31, 2017 · 0 comments
Closed

Should allow autofocus to be disabled. #813

mikepc opened this issue May 31, 2017 · 0 comments

Comments

@mikepc
Copy link

mikepc commented May 31, 2017

HAVE YOU ALREADY SEARCHED FOR SIMILAR ISSUES? PLEASE HELP US OUT AND DOUBLE-CHECK FIRST!

ALSO, PLEASE DON'T BE THAT PERSON WHO DELETES THIS TEMPLATE. IT'S HERE FOR A REASON.

THANKS!

WHICH VERSION OF REACT ARE YOU USING?

Officially Supported:
[ ] v0.14.x

Community Supported:
[X ] v15.0.x

WHICH BROWSER ARE YOU USING?

Officially Supported:
[ ] IE 9 / IE 10 / IE 11
[ ] Edge
[X] Chrome

Should work:
[ ] Firefox
[ ] Safari

I'm submitting a ... (check one with "x")

[ ] bug report
[X] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/adazzle/react-data-grid/blob/master/CONTRIBUTING.md

Current behavior
This is related to #704

Expected/desired behavior
Could we have a property that would disable autofocus altogether? I have a page with 2 grids on it, and the page is automatically scrolled down whenever the page loads. The users are complaining.

Reproduction of the problem
Place one grid at the top of the page , add some (longish) content and add a grid at the bottom of the page. When that page loads in Chrome it will scroll to the bottom grid.

What is the expected behavior?
The grid should not specify scroll behavior, it is just another part of the page.

What is the motivation / use case for changing the behavior?
Any page that has multiple grids should be able to do so without having to "hack" auto-scrolling with a timeout or something else like that.
supamanda pushed a commit to supamanda/react-data-grid that referenced this issue Jun 23, 2017
Allow autofocus to be configured so that the developer can choose whe…
c0ca889 
…ther the grid can steal focus from the body (adazzle#813)
@supamanda supamanda mentioned this issue Jun 23, 2017
Closed
3 tasks
supamanda pushed a commit to supamanda/react-data-grid that referenced this issue Jun 23, 2017
Allow autofocus to be configured so that the developer can choose whe…
9ab8687 
…ther the grid can steal focus from the body (adazzle#813)
@supamanda supamanda mentioned this issue Jun 23, 2017
Merged
3 tasks
supamanda pushed a commit to supamanda/react-data-grid that referenced this issue Jun 26, 2017
set enableAutoFocus to true by default, and add tests for the enableA…
68a6ddb 
…utoFocus configuration (adazzle#813)
malonecj pushed a commit that referenced this issue Nov 6, 2017
@supamanda @malonecj
Allow developer to configure auto focus on the grid (addresses #813) (#…
3dbc315 
…845)

* Allow autofocus to be configured so that the developer can choose whether the grid can steal focus from the body (#813)

* set enableAutoFocus to true by default, and add tests for the enableAutoFocus configuration (#813)

* Update Cell's enableCellAutoFocus tests to reflect change to using ref instead of ReactDOM to find node to focus on

* Change render function name for Cell's enableCellAutoFocus tests so it is unique
@malonecj malonecj closed this as completed Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikepc @malonecj