Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow developer to configure auto focus on the grid (addresses #813) #844

Closed
wants to merge 2 commits into from

Conversation

supamanda
Copy link
Contributor

Description

A PR to allow developer to configure whether the grid should steal focus when the browser is focused on the body. Addresses #813

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
The grid steals focus when the browser is focused on the body, see #813

What is the new behavior?
Allow developer to configure whether grid should autofocus when browser is focused on the body

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c0ca889 on supamanda:ah-configure-auto-focus into ** on adazzle:master**.

@supamanda supamanda closed this Jun 23, 2017
@supamanda
Copy link
Contributor Author

supamanda commented Jun 23, 2017

There was a problem with this PR because it's contaminated with #843 - have opened #845 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants