updates & cleanup #19
Conversation
stefanpenner
commented
May 20, 2015
stefanpenner
commented
- upgrade to latest ember-cli
- remove unused files
- upgrade to some fancy ES2015 syntax
- enable ember-try
- still some test failures, i'll revisit later today.
- fix deprecations
- remove ObjectController usage.
* upgrade to latest ember-cli * remove unused files * upgrade to some fancy ES2015 syntax * enable ember-try
|
Looks good! The fail is related to: emberjs/ember.js#11221 (just incase anyone stumbles upon this.) |
|
@Robdel12 ah ok. Is that the source of all the failures or just this one? |
|
Yeah that's what it looks like. I'm on mobile and the Travis output is hard to read so I might have missed something :p |
Ya I can confirm (well for stable releases, canary is another story...) |
|
@Robdel12 as stable failure is expected, what would you suggest the next steps should be? I'll work on the other failures, and report accordingly. The reality is, this isn't much different then the state on master currently.. |
|
@stefanpenner Man I didn't even look at canary's test fails. Glimmer did a number on it :P I'm not sure how to go about fixing the fails on the other versions (1.11, 1.12). Since it seems to be an ember bug It'd be nice to see that fixed so we can get this merged in and work on canary related fails. I'd love to help with the ember bug but I'm not sure where it's busted. I dug around in the source for an hour and didn't come out with anything. |
| 'ember': 'canary' | ||
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
Can we add Ember 1.10 to this?
|
@Robdel12 added, it is also the only one to pass. |
|
@stefanpenner I expected that. Really interested what changed between 1.10 vs 1.11 with binding attrs. |
|
@Robdel12 @stefanpenner is there anything I can help out with to get this PR merged? Keen to upgrade to ember-cli 0.2.4. |
|
@nikz you can update to ember cli 0.2.4 but you can't update to Ember 1.11+ yet if you are binding the There is a running bug ticket on ember that @stefanpenner and friends have been doing some great work on :) emberjs/ember.js#11221 (comment) |
|
@Robdel12 my suggestion would be to merge this. As it only accurately represents the current state. We can likely get the form fix in shortly to ember, we just have to settle on which way to solve it Is there anything with this pr I can improve? |
|
How about we just conditionally skip the test on the versions that are failing. |
but they are actually legitimately failing. Should we maybe move them to allowed failures? |
|
Closing this since we've had a couple PRs that do this. |
