JDK22+ Mac x64 builds cannot be tested on MacOS versions below 11

[adamfarley]

What are you trying to do?

Ensure all JDK22+ Mac x64 tests are run with a node label that excludes the one MacOS test node using a version under 11.

Expected behaviour:

The node label for all testing should include a "!sw.os.osx.10_14".

Observed behaviour:

https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk22/job/jdk22-mac-x64-temurin/15/

We fail when we get to the smoke tests on a 10.14 machine. Error message:

00:43:53  =JAVA VERSION OUTPUT BEGIN=
00:43:53  dyld: lazy symbol binding failed: Symbol not found: _objc_opt_respondsToSelector
00:43:53    Referenced from: /Users/jenkins/workspace/build-scripts/jobs/jdk22/jdk22-mac-x64-temurin_SmokeTests/jdkbinary/j2sdk-image/Contents/Home/lib/libjava.dylib (which was built for Mac OS X 11.0)
00:43:53    Expected in: /usr/lib/libobjc.A.dylib

Any other comments:

Discovered here, discussed here, and documented here.

[adamfarley]

Draft PR created here, which was based on this fix here.

Being tested here: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk22/job/jdk22-mac-x64-temurin/18/console

[adamfarley]

The additional test label isn't being passed down to the smoke test job. I think this is because we pass the point where the modified code is called before the pipeline reaches the stage where we can modify it via jenkins job parameter.

Here's a run where we do use the modified code: https://ci.adoptium.net/job/build-scripts/job/openjdk22-pipeline/128/console

[smlambert]

To resolve the issue described in #949 (comment), try adding
context.string(name: 'LABEL_ADDITION', value: additionalTestLabel),
to this section of code.

[adamfarley]

Thanks Shelley. I think it's already there, I just wasn't running my modified code due to the hard-coded pipeline repo/branch value for ci-jenkins-pipeline. I've hit this before, I just forgot about it.

My rerun here definitely uses my modified code.

[adamfarley]

Ok, that works! Requesting reviews now.

[adamfarley]

PR merged, issue closed.