Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit xMac JDK22+ testing to MacOS v11+ #950

Conversation

adamfarley
Copy link
Contributor

...because JDK22 and up are not built to be usable on MacOS versions under 11.

...because JDK22 and up are not built to be usable on MacOS versions
under 11.

Signed-off-by: Adam Farley <[email protected]>
@adamfarley adamfarley self-assigned this Feb 29, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@adamfarley
Copy link
Contributor Author

Fixes #949

@adamfarley
Copy link
Contributor Author

@adamfarley
Copy link
Contributor Author

Update, I re-tested a copy of this fix here, plus some debug code to prove it's definitely using our modified code.

https://ci.adoptium.net/job/build-scripts/job/openjdk22-pipeline/128/console

Note: The debug code is not included in this PR.

@adamfarley adamfarley enabled auto-merge (squash) March 1, 2024 14:15
@adamfarley adamfarley merged commit 05f0d8d into adoptium:master Mar 1, 2024
3 of 4 checks passed
@adamfarley
Copy link
Contributor Author

run tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants