Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openj9 XL spec cleanup #163

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Openj9 XL spec cleanup #163

merged 1 commit into from
Jun 9, 2021

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jun 7, 2021

Related #23

Signed-off-by: Sophia Guo [email protected]

@sophia-guo sophia-guo marked this pull request as draft June 7, 2021 21:43
@github-actions github-actions bot added generation Issues that provide enhancements or fixes to the job generators jenkins-pipeline openj9 labels Jun 7, 2021
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

@karianna karianna added this to the June 2021 milestone Jun 8, 2021
Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo
Copy link
Contributor Author

@AdamBrousseau is it a good time for this clean up? Thanks.

Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. I'm not sure what estimatedKey is used for to be honest and I've never liked how additionalFilename param was handled (hardcoded to xl). I don't believe the filename addition is used for anything else. I think we can leave the param but remove the xl code for it as you have done.

@sophia-guo sophia-guo marked this pull request as ready for review June 9, 2021 19:18
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams gdams merged commit 5247c3a into adoptium:master Jun 9, 2021
AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generation Issues that provide enhancements or fixes to the job generators jenkins-pipeline openj9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants