Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable OpenJ9 XL Specs #23

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Disable OpenJ9 XL Specs #23

merged 1 commit into from
Feb 22, 2021

Conversation

AdamBrousseau
Copy link
Contributor

Turn off large heap platforms in the ci builds.
More cleanup can be done related to xl packages
once the dust settles.

Depends #22

Signed-off-by: Adam Brousseau [email protected]

@github-actions
Copy link

Thank you for creating a pull request!
In order to run the pipeline tests I require an admin to post the following comment: run-tests

@karianna karianna added this to the February 2021 milestone Feb 10, 2021
karianna
karianna approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams
Copy link
Member

gdams commented Feb 10, 2021

run-tests

@gdams
Copy link
Member

gdams commented Feb 10, 2021

run tests

llxia
llxia approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

M-Davies
M-Davies requested changes Feb 10, 2021
View reviewed changes
Copy link

@M-Davies M-Davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the build config values from the jdkxx_pipeline_config.groovy files too?

@AdamBrousseau
Copy link
Contributor Author

@M-Davies is that needed to disable the builds? I was thinking that would be part of the follow up cleanup.

@M-Davies
Copy link

@M-Davies is that needed to disable the builds? I was thinking that would be part of the follow up cleanup.

Shouldn't they be removed at the same time? It would allow for an easier revert later down the line in case we decide to add XL specs back in?

@AdamBrousseau
Copy link
Contributor Author

I guess it's up to Adopt. By that argument we should remove all xl related stuff in 1 PR. I don't think there'll be need to revert once the seconds PR cleans up all the xl related code.

@adoptopenjdk-github-bot
Copy link
Contributor

PR TESTER RESULT 

✅ All pipelines passed! ✅

@AdamBrousseau
Copy link
Contributor Author

Can I leave it up to Adopt folks to determine if there are other areas that need changes? Website, API, Docker etc. There will be existing released XL builds but going forward there will only be the default build.

M-Davies
M-Davies approved these changes Feb 11, 2021
View reviewed changes
Copy link

@M-Davies M-Davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok for improving this for now but we should clarify how to remove and/or disable platforms in the future (preferably in the FAQ)

@M-Davies
Copy link

I'm ok for improving this for now but we should clarify how to remove and/or disable platforms in the future (preferably in the FAQ)

In fact, we already clarified it.

@karianna
Copy link
Contributor

@AdamBrousseau rebase sorry!

@AdamBrousseau AdamBrousseau marked this pull request as draft February 16, 2021 16:18
@AdamBrousseau
Disable OpenJ9 XL Specs
5e3825b 
Turn off large heap platforms in the ci builds.
More cleanup can be done related to xl packages
once the dust settles.

Depends adoptium#22

Signed-off-by: Adam Brousseau <[email protected]>
@AdamBrousseau
Copy link
Contributor Author

Rebased. Set as draft until 22 is merged.

@gdams
Copy link
Member

gdams commented Feb 22, 2021

@AdamBrousseau can we merge this now?

@AdamBrousseau AdamBrousseau marked this pull request as ready for review February 22, 2021 19:06
@AdamBrousseau
Copy link
Contributor Author

Yes I think we're ready for this.

@gdams gdams merged commit b6db736 into adoptium:master Feb 22, 2021
@gdams
Copy link
Member

gdams commented Feb 22, 2021

It would be good to clear up the XL build jobs from the active versions in jenkins. @M-Davies I wonder whether we can modify the generator jobs to cleanup jobs that are no longer defined?

@pshipton pshipton mentioned this pull request Feb 24, 2021
Closed
@sophia-guo sophia-guo mentioned this pull request Jun 9, 2021
Merged
AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this pull request Oct 1, 2021
@AdamBrousseau
Merge pull request adoptium#23 from vsebe/ibm
d5f000f 
Replace --enable-dtrace=auto with --enable-dtrace
@andrew-m-leonard andrew-m-leonard mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-Davies M-Davies M-Davies approved these changes

@gdams gdams gdams approved these changes

@llxia llxia llxia approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
February 2021
Development

Successfully merging this pull request may close these issues.
6 participants
@AdamBrousseau @gdams @M-Davies @adoptopenjdk-github-bot @karianna @llxia