Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JDK20/21 on Linux/x64 to CentOS7 instead of CentOS6 #627

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

sxa
Copy link
Member

@sxa sxa commented Feb 22, 2023

Red Hat's portable builds of all LTS versions already support only 7 and later. This will bring our X64 builds for JDK20 and the new LTS release of 21 later this year in line with the other Linux architectures and move the required glibc level up accordingly for consistency.
For now I am nor proposing any change to the prior LTS releases.
Similar to the changes we have proposed for Win32 and AIX, we will use the short-term-support JDK20 to gauge response in advance of the next LTS release.

@sxa sxa self-assigned this Feb 22, 2023
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,19"

@github-actions github-actions bot added jenkins-pipeline x64 Issues that affect or relate to the x64/x32 LINUX OS labels Feb 22, 2023
@sxa
Copy link
Member Author

sxa commented Feb 22, 2023

No idea what's going on with that linter check since it seems to have passed the files I've changed without problems: @andrew-m-leonard do we have known issues with the linter in this repo just now?

2023-02-22 17:34:24 [INFO]   File:[/github/workspace/pipelines/jobs/configurations/jdk20_pipeline_config.groovy]
2023-02-22 17:34:25 [INFO]    - File:[jdk20_pipeline_config.groovy] was linted with [jscpd] successfully
2023-02-22 17:34:25 [INFO]      - Command output:
------
Found 0 clones.
Detection time:: 33.711ms
------
2023-02-22 17:34:25 [INFO]   ---------------------------
2023-02-22 17:34:25 [INFO]   File:[/github/workspace/pipelines/jobs/configurations/jdk21_pipeline_config.groovy]
2023-02-22 17:34:25 [INFO]    - File:[jdk21_pipeline_config.groovy] was linted with [jscpd] successfully
2023-02-22 17:34:25 [INFO]      - Command output:
------
Found 0 clones.
Detection time:: 34.768ms
------
2023-02-22 17:34:27 [INFO]   ----------------------------------------------
2023-02-22 17:34:27 [INFO]   ----------------------------------------------
2023-02-22 17:34:27 [INFO]   The script has completed
2023-02-22 17:34:27 [INFO]   ----------------------------------------------
2023-02-22 17:34:27 [INFO]   ----------------------------------------------
2023-02-22 17:34:27 [INFO]   ERROR! Failed to call GitHub Status API!
2023-02-22 17:34:27 [INFO]   ERROR:[curl: (22) The requested URL returned error: 403]
2023-02-22 17:34:27 [ERROR]   ERRORS FOUND in GROOVY:[2]
2023-02-22 17:34:28 [INFO]   ERROR! Failed to call GitHub Status API!
2023-02-22 17:34:28 [INFO]   ERROR:[curl: (22) The requested URL returned error: 403]
2023-02-22 17:34:28 [INFO]   ERROR! Failed to call GitHub Status API!
2023-02-22 17:34:28 [INFO]   ERROR:[curl: (22) The requested URL returned error: 403]
2023-02-22 17:34:28 [FATAL]   Exiting with errors found!

@karianna
Copy link
Contributor

@sxa You have : twice on each line, hard up against the label and then tabbed out, I'll try to fix in place....

@karianna
Copy link
Contributor

@sxa sorry, no super powers to force that through

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve subject to extra ":" deletion

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sxa
Copy link
Member Author

sxa commented Feb 23, 2023

@sxa You have : twice on each line, hard up against the label and then tabbed out, I'll try to fix in place....

I stared at the diff and still managed to miss that - thanks :-) Linter happy now - merging

@sxa sxa merged commit 9692d8e into adoptium:master Feb 23, 2023
@sxa sxa deleted the xlinuxEL6 branch February 23, 2023 10:42
@sxa
Copy link
Member Author

sxa commented Feb 23, 2023

Sharing this here for reference because I have the info and it's sort-of-related. Here are the attempts to run various JDK8 versions from the Adoptium Marketplace on CentOS6/RHEL6:

[root@69c88c9c1211 tmp]# for A in */bin/java; do echo ===== $A; $A -version; done
===== bisheng-jdk1.8.0_362/bin/java
openjdk version "1.8.0_362"
OpenJDK Runtime Environment BiSheng (build 1.8.0_362-b11)
OpenJDK 64-Bit Server VM BiSheng (build 25.362-b11, mixed mode)
===== dragonwell-8.14.15/bin/java
openjdk version "1.8.0_362"
OpenJDK Runtime Environment (Alibaba Dragonwell Standard Edition 8.14.15) (build 1.8.0_362-b01)
OpenJDK 64-Bit Server VM (Alibaba Dragonwell Standard Edition 8.14.15) (build 25.362-b01, mixed mode)
===== java-17-openjdk-17.0.6.0.10-2.portable.jdk.el.x86_64/bin/java
java-17-openjdk-17.0.6.0.10-2.portable.jdk.el.x86_64/bin/java: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /tmp/java-17-openjdk-17.0.6.0.10-2.portable.jdk.el.x86_64/bin/../lib/libjli.so)
===== java-1.8.0-openjdk-portable-1.8.0.362.b08-1.portable.jdk.el.x86_64/bin/java
java-1.8.0-openjdk-portable-1.8.0.362.b08-1.portable.jdk.el.x86_64/bin/java: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /tmp/java-1.8.0-openjdk-portable-1.8.0.362.b08-1.portable.jdk.el.x86_64/bin/../lib/amd64/jli/libjli.so)
===== zulu8.68.0.21-ca-jdk8.0.362-linux_x64/bin/java
openjdk version "1.8.0_362"
OpenJDK Runtime Environment (Zulu 8.68.0.21-CA-linux64) (build 1.8.0_362-b09)
OpenJDK 64-Bit Server VM (Zulu 8.68.0.21-CA-linux64) (build 25.362-b09, mixed mode)
[root@69c88c9c1211 tmp]# 

@wendigo
Copy link

wendigo commented Aug 30, 2023

This effectively moved JDK builds to link against GLIBC 2.14 where previously it was linked against GLIBC 2.12.

Is this intended? In comparison, Azul JDK builds still links against 2.12.

luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-pipeline x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants