-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move JDK20/21 on Linux/x64 to CentOS7 instead of CentOS6 #627
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
No idea what's going on with that linter check since it seems to have passed the files I've changed without problems: @andrew-m-leonard do we have known issues with the linter in this repo just now?
|
@sxa You have |
@sxa sorry, no super powers to force that through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve subject to extra ":" deletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Signed-off-by: Stewart X Addison <[email protected]>
I stared at the diff and still managed to miss that - thanks :-) Linter happy now - merging |
Sharing this here for reference because I have the info and it's sort-of-related. Here are the attempts to run various JDK8 versions from the Adoptium Marketplace on CentOS6/RHEL6:
|
This effectively moved JDK builds to link against GLIBC 2.14 where previously it was linked against GLIBC 2.12. Is this intended? In comparison, Azul JDK builds still links against 2.12. |
Signed-off-by: Stewart X Addison <[email protected]>
Red Hat's portable builds of all LTS versions already support only 7 and later. This will bring our X64 builds for JDK20 and the new LTS release of 21 later this year in line with the other Linux architectures and move the required glibc level up accordingly for consistency.
For now I am nor proposing any change to the prior LTS releases.
Similar to the changes we have proposed for Win32 and AIX, we will use the short-term-support JDK20 to gauge response in advance of the next LTS release.