-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit from setupAntEnv is not propagated to its only usecase #3839
Conversation
This reverts commit 895dd6a.
We ahve to ensure it is fatal, co calling it one more times
spellcheck should have warned to this: https://www.shellcheck.net/wiki/SC2155#problematic-code-in-the-case-of-local |
Hard to say where it is intentional:
its usually some terrible |
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
@karianna thanx. The smallest I can do as a gratitude for your patience, is to sign myself up for some english class over summer:( do x does.. what a shame... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like @andrew-m-leonard to review this one too since it's part of the setup for CycloneDX SBOM generation, so adding him as an approver. LGTM though. (Reviewing this as a "Comment" instead of "Approve" so that it doesn't get a second approval and merged until Andrew has approved!
Coincidentally this is related to a shellcheck exclusion that I queried in another PR today.
It is clear bug. If it do not fail asap, it will die later, just in not debugg-able exetption. Thanx for eyball! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good, I didn't realise it did that...!
ty! |
I had hit this when I forget to run all the build chain with JAVA_HOME set. It died, but without any trace. This PR is adding the trace of what went wrong.