Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build-scripts to enable hotspot & temurin jdk(head) version branch builds #3852

Merged
merged 10 commits into from
Jun 17, 2024
Merged

Update build-scripts to enable hotspot & temurin jdk(head) version branch builds #3852

merged 10 commits into from
Jun 17, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Jun 14, 2024 •
edited
Loading

Fixes: #3841

Provides support for building jdk-23+ for hotspot and temurin, from the jdk(head) version branches.

"hotspot" build tests:

@andrew-m-leonard andrew-m-leonard self-assigned this Jun 14, 2024
@github-actions github-actions bot added the testing Issues that enhance or fix our test suites label Jun 14, 2024
@andrew-m-leonard andrew-m-leonard requested review from sxa and karianna June 14, 2024 15:40
@sxa sxa mentioned this pull request Jun 15, 2024
Closed
@andrew-m-leonard
Copy link
Contributor Author

@sxa for review please

sxa
sxa approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops just realised I didn't submit this review before our call.
As far as I can tell this is good. Do we really need the extra shellcheck exclusion instead of splitting the assignment of the variable into two lines though? I won't block regardless.

sbin/common/common.sh Outdated Show resolved Hide resolved
@sxa sxa mentioned this pull request Jun 17, 2024
Merged
@andrew-m-leonard @sxa
Update sbin/common/common.sh
1d328f3 
Co-authored-by: Stewart X Addison <[email protected]>
@andrew-m-leonard andrew-m-leonard merged commit 182047c into adoptium:master Jun 17, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa approved these changes

@karianna karianna karianna approved these changes

Assignees

@andrew-m-leonard andrew-m-leonard

Labels
testing Issues that enhance or fix our test suites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upstream openjdk/jdk(head) now branching releases rather than forking
3 participants
@andrew-m-leonard @karianna @sxa