Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification working #448

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Notification working #448

merged 1 commit into from
Jan 2, 2025

Conversation

foucblg
Copy link
Contributor

@foucblg foucblg commented Nov 25, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.18%. Comparing base (0200665) to head (ed08407).

Files with missing lines Patch % Lines
lib/service/class/message.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   54.06%   54.18%   +0.11%     
==========================================
  Files         169      169              
  Lines        3747     3739       -8     
==========================================
  Hits         2026     2026              
+ Misses       1721     1713       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maximeroucher maximeroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds go to me !
Just wait for the back to be merged before merging this one

@maximeroucher maximeroucher added notification This PR works on notification fix bug This PR fix a bug waiting backend labels Nov 25, 2024
@Marc-Andrieu Marc-Andrieu mentioned this pull request Dec 25, 2024
5 tasks
@maximeroucher maximeroucher merged commit 7412931 into main Jan 2, 2025
4 checks passed
@maximeroucher maximeroucher deleted the front-notification branch January 2, 2025 19:43
foucblg pushed a commit that referenced this pull request Jan 6, 2025
> [!IMPORTANT]
> We really need to release new versions **soon**, as we have not for
several months and there's some time needed to test in alpha before
prod.

This goes hand in hand with the **major version bump** [for
Hyperion](../../Hyperion/pull/642).

Both PRs are ready, and _seemingly_ waiting for some more **breaking
changes** to be merged, including (by likelihood):

- [x] Support Flutter 3.27: #464
- [ ] Allow students from other Schools to have a MyECL account: #447 
- [ ] MyECLPay: #72 (old PR but recent branch)
- [ ] "_Centrale Mega Meme_" Meme module: #461 
- [x] External Notifications: #448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix bug This PR fix a bug notification This PR works on notification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants