Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter 3.27 #464

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Flutter 3.27 #464

merged 6 commits into from
Jan 2, 2025

Conversation

Marc-Andrieu
Copy link
Contributor

Replaces and closes #463 with @Rotheem's branch
Goal of this PR: see the title of #463

@Marc-Andrieu Marc-Andrieu added ci/cd This PR works on the CI/CD dependencies Pull requests that update a dependency file labels Dec 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 54.06%. Comparing base (1b70721) to head (c718205).

Files with missing lines Patch % Lines
lib/auth/providers/openid_provider.dart 0.00% 11 Missing ⚠️
lib/auth/repository/openid_repository.dart 0.00% 2 Missing ⚠️
lib/tools/functions.dart 0.00% 2 Missing ⚠️
lib/tools/repository/logo_repository.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   54.04%   54.06%   +0.02%     
==========================================
  Files         169      169              
  Lines        3749     3747       -2     
==========================================
  Hits         2026     2026              
+ Misses       1723     1721       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marc-Andrieu Marc-Andrieu mentioned this pull request Dec 25, 2024
5 tasks
@Rotheem Rotheem added the ready for review This PR is ready to be reviewed label Dec 26, 2024
@maximeroucher maximeroucher merged commit 1f37eb3 into main Jan 2, 2025
6 checks passed
@maximeroucher maximeroucher deleted the flutter-3.27 branch January 2, 2025 19:00
foucblg pushed a commit that referenced this pull request Jan 6, 2025
> [!IMPORTANT]
> We really need to release new versions **soon**, as we have not for
several months and there's some time needed to test in alpha before
prod.

This goes hand in hand with the **major version bump** [for
Hyperion](../../Hyperion/pull/642).

Both PRs are ready, and _seemingly_ waiting for some more **breaking
changes** to be merged, including (by likelihood):

- [x] Support Flutter 3.27: #464
- [ ] Allow students from other Schools to have a MyECL account: #447 
- [ ] MyECLPay: #72 (old PR but recent branch)
- [ ] "_Centrale Mega Meme_" Meme module: #461 
- [x] External Notifications: #448
maximeroucher pushed a commit that referenced this pull request Jan 11, 2025
Replaces and closes #463 with @Rotheem's branch
Goal of this PR: see the title of #463

---------

Co-authored-by: Thonyk <[email protected]>
maximeroucher pushed a commit that referenced this pull request Jan 14, 2025
Replaces and closes #463 with @Rotheem's branch
Goal of this PR: see the title of #463

---------

Co-authored-by: Thonyk <[email protected]>
Rotheem added a commit that referenced this pull request Jan 15, 2025
Replaces and closes #463 with @Rotheem's branch
Goal of this PR: see the title of #463

---------

Co-authored-by: Thonyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build ci/cd This PR works on the CI/CD dependencies Pull requests that update a dependency file ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants