FMWK-55 Supporting Map and List filtering (integer only), refactoring Qualifier, AerospikeCriteria, AerospikeQueryCreator #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrgr
commented
Oct 12, 2022
•
agrgr
commented
- refactoring Qualifier switch-case
- Qualifier telescoping constructors into a Builder
- AerospikeCriteria constructors into a Builder
- Qualifier FilterOperation enum out as a separate class
- removing Criteria class
- adding support for querying by map elements similar to findByPojoField
- increasing readability, reducing excessive code etc.
- test coverage
…eld for the first level POJOs
…eld for the first level POJOs
…tors, initial commit
…changes in the branch FMWK-54
…lterOperation enum on an upper level
…ring Qualifier, AerospikeQueryCreator, FilterOperation
reugn
changed the title
reugn
approved these changes
Oct 12, 2022
…st (filtering by string elements is not supported so far due to clientside)
…alifier-constructors # Conflicts: # src/main/java/org/springframework/data/aerospike/query/Qualifier.java # src/test/java/org/springframework/data/aerospike/repository/PersonRepositoryQueryTests.java # src/test/java/org/springframework/data/aerospike/sample/Person.java
…alifier-constructors # Conflicts: # src/main/java/org/springframework/data/aerospike/query/Qualifier.java # src/main/java/org/springframework/data/aerospike/repository/query/AerospikeQueryCreator.java # src/test/java/org/springframework/data/aerospike/repository/PersonRepositoryQueryTests.java # src/test/java/org/springframework/data/aerospike/sample/Person.java
…alifier-constructors
…teria-and-Qualifier-constructors' into FMWK-55-refactoring-AerospikeCriteria-and-Qualifier-constructors
agrgr
changed the title
…alifier-constructors # Conflicts: # src/test/java/org/springframework/data/aerospike/repository/PersonRepositoryQueryTests.java
…alifier-constructors
roimenashe
reviewed
Oct 16, 2022
src/test/java/org/springframework/data/aerospike/sample/PersonRepository.java
Show resolved
Hide resolved
…teria-and-Qualifier-constructors' into FMWK-55-refactoring-AerospikeCriteria-and-Qualifier-constructors
…teria-and-Qualifier-constructors' into FMWK-55-refactoring-AerospikeCriteria-and-Qualifier-constructors
roimenashe
reviewed
Oct 16, 2022
| @@ -67,7 +67,11 @@ public Qualifier getCriteriaObject() { | |||
| for (Criteria c : this.criteriaChain) { | |||
| qualifiers.add(c.getCriteriaObject()); | |||
| } | |||
| return new Qualifier(op, qualifiers.toArray(new Qualifier[0])); | |||
| // return new Qualifier(op, qualifiers.toArray(new Qualifier[0])); | |||
There was a problem hiding this comment.
Criteria class is going to be removed (as discussed)
roimenashe
approved these changes
Oct 16, 2022
…alifier-constructors
ijusti
approved these changes
Oct 18, 2022
…teria-and-Qualifier-constructors' into FMWK-55-refactoring-AerospikeCriteria-and-Qualifier-constructors # Conflicts: # src/main/java/org/springframework/data/aerospike/query/FilterOperation.java # src/test/java/org/springframework/data/aerospike/sample/PersonRepository.java
@ijusti, there is secondary index related work left, as far as I know |
roimenashe
approved these changes
Oct 19, 2022
roimenashe
reviewed
Oct 20, 2022
| } | ||
|
|
||
| @Override | ||
| public Filter secIndexFilter(Map<String, Object> map) { |
There was a problem hiding this comment.
Please change secIndexFilter to sIndexFilter (it's more common in most of Aerospike documentation regarding secondary indexes).
roimenashe
reviewed
Oct 20, 2022
| protected Filter geoWithinRadius(IndexCollectionType collectionType, Map<String, Object> map) { | ||
| return Filter.geoContains(getField(map), getValue1(map).toString()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove 3 unnecessary spaces.
reugn
deleted the
FMWK-55-refactoring-AerospikeCriteria-and-Qualifier-constructors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.