Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMWK-55 Supporting Map and List filtering (integer only), refactoring Qualifier, AerospikeCriteria, AerospikeQueryCreator #434

Merged
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
986d322
FMWK-44, support for findByPOJO/Association: support for findByPojoFi…
agrgr Sep 21, 2022
acf18af
FMWK-44, support for findByPOJO/Association: support for findByPojoFi…
agrgr Sep 22, 2022
24b6a11
FMWK-54, support for findByPOJOField comparison: added MAP_KEY_VALUE_…
agrgr Sep 25, 2022
46bef2f
comparison operations for findByPOJOField: GT, GTE, LT, LTE, BETWEEN
agrgr Sep 29, 2022
3be77ff
cleanup in some of the new tests
agrgr Sep 29, 2022
a54530e
minor naming cleanup
agrgr Sep 29, 2022
9d25cec
applying Builder to refactor AerospikeCriteria and Qualifier construc…
agrgr Oct 2, 2022
5e99232
aligning Qualifier FilterOperation names and Javadoc with the latest …
agrgr Oct 2, 2022
01edafc
replacing telescoping constructors in Qualifier to Builder, moving Fi…
agrgr Oct 6, 2022
8a8d543
minor cleanup
agrgr Oct 6, 2022
8343ddc
FMWK-55: adding support for search by map key + value, tests, refacto…
agrgr Oct 12, 2022
6403f39
FMWK-55: adding support for filtering by an integer value inside a li…
agrgr Oct 12, 2022
a9a4fc4
Merge branch 'main' into FMWK-55-refactoring-AerospikeCriteria-and-Qu…
agrgr Oct 12, 2022
e01ffb2
merged main into FMWK-55
agrgr Oct 12, 2022
d782cf8
Merge branch 'main' into FMWK-55-refactoring-AerospikeCriteria-and-Qu…
agrgr Oct 12, 2022
162890b
merged main into FMWK-55
agrgr Oct 12, 2022
0c4e45a
Merge branch 'main' into FMWK-55-refactoring-AerospikeCriteria-and-Qu…
roimenashe Oct 12, 2022
dd00a44
supporting the initial logic of not setting Criteria values if they =…
agrgr Oct 13, 2022
ccc746a
Merge remote-tracking branch 'origin/FMWK-55-refactoring-AerospikeCri…
agrgr Oct 13, 2022
c6c7e09
minor cleanup
agrgr Oct 13, 2022
c09f74d
minor test update
agrgr Oct 13, 2022
70c35b9
Merge branch 'main' into FMWK-55-refactoring-AerospikeCriteria-and-Qu…
agrgr Oct 13, 2022
b66c380
Merge branch 'main' into FMWK-55-refactoring-AerospikeCriteria-and-Qu…
roimenashe Oct 16, 2022
9a0f5fe
clean up code
reugn Oct 16, 2022
6ca7f33
adding tests
agrgr Oct 16, 2022
858c039
Merge remote-tracking branch 'origin/FMWK-55-refactoring-AerospikeCri…
agrgr Oct 16, 2022
c6524de
Format AerospikePartTreeQuery (spaces instead of tabs, alignment).
roimenashe Oct 16, 2022
6cddf13
Merge remote-tracking branch 'origin/FMWK-55-refactoring-AerospikeCri…
roimenashe Oct 16, 2022
2dfd36c
Format.
roimenashe Oct 16, 2022
69b4c0f
Cleanup.
roimenashe Oct 16, 2022
c864439
Merge branch 'main' into FMWK-55-refactoring-AerospikeCriteria-and-Qu…
roimenashe Oct 18, 2022
c6154bd
adding tests, test related fixes, cleanup
agrgr Oct 18, 2022
9a92891
Merge remote-tracking branch 'origin/FMWK-55-refactoring-AerospikeCri…
agrgr Oct 18, 2022
527b73d
test related fixes, cleanup
agrgr Oct 18, 2022
dd4e4de
removing Criteria class
agrgr Oct 18, 2022
dc9b6aa
refactoring: removing Criteria class
agrgr Oct 18, 2022
d66d6c4
minor cleanup
agrgr Oct 19, 2022
a4eaaff
refactoring: switch-case in Qualifier.asFilter() to FilterOperation, …
agrgr Oct 20, 2022
627a9df
minor cleanup
agrgr Oct 20, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ public class ExpiryQualifier extends Qualifier {
private static final long serialVersionUID = 13172814137477042L;

public ExpiryQualifier(FilterOperation op, Value value) {
super(QueryEngine.Meta.EXPIRATION.toString(), op, value);
super(new QualifierBuilder()
.setField(QueryEngine.Meta.EXPIRATION.toString())
.setFilterOperation(op)
.setValue1(value)
);
if (value.getType() != ParticleType.INTEGER) {
throw new QualifierException("ExpiryQualifier value must be an integer or long");
}
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,19 @@ public class KeyQualifier extends Qualifier {
boolean hasDigest = false;

public KeyQualifier(Value value) {
super(QueryEngine.Meta.KEY.toString(), FilterOperation.EQ, value);
super(new QualifierBuilder()
.setField(QueryEngine.Meta.KEY.toString())
.setFilterOperation(FilterOperation.EQ)
.setValue1(value)
);
}

public KeyQualifier(byte[] digest) {
super(QueryEngine.Meta.KEY.toString(), FilterOperation.EQ, null);
super(new QualifierBuilder()
.setField(QueryEngine.Meta.KEY.toString())
.setFilterOperation(FilterOperation.EQ)
.setValue1(null)
);
this.internalMap.put("digest", digest);
this.hasDigest = true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ public class LatestUpdateQualifier extends Qualifier {
private static final long serialVersionUID = -8767573059309320133L;

public LatestUpdateQualifier(FilterOperation op, Value value) {
super("latest_update_time", op, value); // the field should never be used as here we use a bit different logic
super(new QualifierBuilder()
.setField("latest_update_time")
.setFilterOperation(op)
.setValue1(value)
);
if (value.getType() != ParticleType.INTEGER) {
throw new QualifierException("LatestUpdateQualifer value must be an integer or long");
}
Expand Down
Loading