AgentCharaCard: Fix reading decorations #1269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redstrate
commented
Jan 3, 2025
I'm a total idiot and only tested this code against a full adventurer plate, and it turns out almost everything I did was completely wrong. I assumed the location of each decoration is static, but it turns out this structure is more extendable than I thought, I guess to support more decoration types in the future. The decoration data is stored in two different fixed size arrays with five elements (since there's only five decoration types.) The first array is the row indices, where the hard-coded locations were before. The second array is some more decoration information, but currently I only know of and care about the type for now. This does not affect base plates or borders, which are not considered decorations.
Breaking ChangesMember exists in left but not in rightFFXIVClientStructs.FFXIV.Client.UI.Agent.AgentCharaCard: 1Storage: 5
|
github-actions
bot
added
the
breaking change
|
Will be held off until next API bump possibly 7.2 |
Haselnussbomber
added a commit
to Haselnussbomber/FFXIVClientStructs
that referenced
this pull request
Feb 15, 2025
Add: - BannerHelper - CharaCard - AgentBannerPreview - AgentBannerPreviewState - HelperInterface Update: - AgentCharaCard - AgentBannerEditorState - CharaView - CharaViewPortrait - RaptureGearsetModule - UIModuleHelpers - data.yml Closes aers#1269
wolfcomp
pushed a commit
that referenced
this pull request
Feb 15, 2025
* Update Portrait/Adventurer Plate structs Add: - BannerHelper - CharaCard - AgentBannerPreview - AgentBannerPreviewState - HelperInterface Update: - AgentCharaCard - AgentBannerEditorState - CharaView - CharaViewPortrait - RaptureGearsetModule - UIModuleHelpers - data.yml Closes #1269 * Fix size of BannerData * Fix offsets of BannerData * Fix Data8Struct.GearVisibilityFlag type * Restore types of obsoleted fields * Fix offset and comment of obsoletes in CharaViewCharacterData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a total idiot and only tested this code against a full adventurer plate, and it turns out almost everything I did was completely wrong. I assumed the location of each decoration is static, but it turns out this structure is more extendable than I thought, I guess to support more decoration types in the future.
The decoration data is stored in two different fixed size arrays with five elements (since there's only five decoration types.) The first array is the row indices, where the hard-coded locations were before. The second array is some more decoration information, but currently I only know of and care about the type for now.
This does not affect base plates or borders, which are not considered decorations.