Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Portrait/Adventurer Plate structs #1309

Merged
merged 6 commits into from
Feb 15, 2025
Merged

Update Portrait/Adventurer Plate structs #1309

merged 6 commits into from
Feb 15, 2025

Conversation

Haselnussbomber
Copy link
Contributor

@Haselnussbomber Haselnussbomber commented Feb 15, 2025 •
edited
Loading

Added:

  • BannerHelper
  • CharaCard
  • BannerData, CharaCardData, Data8, Data16, Data32 (names from GM command handler)
  • AgentBannerPreview
  • AgentBannerPreviewState
  • HelperInterface

Updated:

  • AgentCharaCard
  • AgentBannerEditorState
  • CharaView
  • CharaViewPortrait
  • RaptureGearsetModule
  • UIModuleHelpers
  • data.yml

Closes #1269

@Haselnussbomber
Update Portrait/Adventurer Plate structs
7a2b3f1 
Add:
- BannerHelper
- CharaCard
- AgentBannerPreview
- AgentBannerPreviewState
- HelperInterface

Update:
- AgentCharaCard
- AgentBannerEditorState
- CharaView
- CharaViewPortrait
- RaptureGearsetModule
- UIModuleHelpers
- data.yml

Closes aers#1269
@github-actions github-actions bot added the requested changes Changes requested through comments label Feb 15, 2025
@github-actions github-actions bot added breaking change PR contains breaking changes and wont be merged before a new patch and removed requested changes Changes requested through comments labels Feb 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Breaking Changes

Member exists in left but not in right

FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewPortrait.Delegates: 1

Setup: 2

  • void Invoke(FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewPortrait*, uint, FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewCharacterData*, long, int, long)
  • System.IAsyncResult BeginInvoke(FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewPortrait*, uint, FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewCharacterData*, long, int, long, System.AsyncCallback, object)

@wolfcomp wolfcomp merged commit ab7a783 into aers:main Feb 15, 2025
4 of 5 checks passed
@Haselnussbomber Haselnussbomber deleted the bannerhelper branch February 15, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change PR contains breaking changes and wont be merged before a new patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Haselnussbomber @wolfcomp