Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small wireless configuration fixes #1753

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Small wireless configuration fixes #1753

merged 4 commits into from
Nov 14, 2024

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Nov 13, 2024

Problem

There are various issues detected when working on this PBI:

  1. The authentication method is not selected properly
  2. The form reports that auhentication failed when it is already connected.
  3. Some times the labels and buttons for the selected wifi does not correspond whith the current state.
  4. After a sync with master branch the backend started failing when reading wireless connections

Solution

We have fixes some of the issues but the handle of state is quite fragile and coupled to the websockets notification in the frontend and the UI therefore we plan to do some changes in the UI (Drawer and selection of the WiFi) as well as in the backend trying to store the authentication state there being able to request the state from the backend without lostling any information in case of not subscribed to changes.

About the fixes in particular:

  1. The authentication method is recognized again (removed method probably by error).
  2. In case that a wireless device is activated the needAuth is also removed from the cached queries
  3. To be better handled.
  4. Get some of the wireless settings as optional (band, channel, bssid, hidden, pmf)

...

Testing

  • Tested manually

@teclator teclator force-pushed the network_state_fixes branch 3 times, most recently from b1d8dc4 to 14edd47 Compare November 14, 2024 13:26
@coveralls
Copy link

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 11838142890

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 433 unchanged lines in 21 files lost coverage.
  • Overall coverage increased (+0.05%) to 71.375%

Files with Coverage Reduction New Missed Lines %
rust/agama-lib/src/network/settings.rs 2 62.5%
rust/agama-lib/src/storage/settings.rs 2 0.0%
rust/agama-lib/src/lib.rs 5 31.25%
rust/agama-lib/src/scripts/model.rs 5 86.11%
rust/agama-server/src/web/docs/l10n.rs 6 0.0%
rust/agama-server/src/web/docs/manager.rs 6 0.0%
rust/agama-server/src/web/docs/misc.rs 6 0.0%
rust/agama-server/src/web/docs/questions.rs 6 0.0%
rust/agama-server/src/web/docs/software.rs 6 0.0%
rust/agama-server/src/web/docs/storage.rs 6 0.0%
Totals Coverage Status
Change from base Build 11831842629: 0.05%
Covered Lines: 16898
Relevant Lines: 23675

💛 - Coveralls

@teclator teclator marked this pull request as ready for review November 14, 2024 14:41
@teclator teclator changed the title Try to fix some WiFi authentication issues Small wireless configuration fixes Nov 14, 2024
@teclator teclator force-pushed the network_state_fixes branch from 79fa774 to 2196163 Compare November 14, 2024 14:54
let mut wireless_config = WirelessConfig {
mode: NmWirelessMode(mode).try_into()?,
ssid: SSID(ssid),
..Default::default()
};

if let Ok(band) = get_property::<String>(wireless, "band") {
if let Some(band) = get_optional_property::<String>(wireless, "band")? {
wireless_config.band = WirelessBand::try_from(band.as_str()).ok();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but I guess we could implement TryFrom<Value<'a>> and get rid of the if block.

web/package/agama-web-ui.changes Outdated Show resolved Hide resolved
Co-authored-by: Imobach González Sosa <[email protected]>
@teclator teclator merged commit 07d5dab into master Nov 14, 2024
6 checks passed
@teclator teclator deleted the network_state_fixes branch November 14, 2024 17:44
@imobachgs imobachgs mentioned this pull request Jan 10, 2025
imobachgs added a commit that referenced this pull request Jan 13, 2025
Update to release version 11.

* #1495
* #1564
* #1617
* #1618
* #1625
* #1626
* #1627
* #1628
* #1630
* #1631
* #1632
* #1633
* #1634
* #1635
* #1636
* #1639
* #1640
* #1641
* #1642
* #1643
* #1644
* #1645
* #1646
* #1647
* #1648
* #1649
* #1650
* #1651
* #1652
* #1654
* #1655
* #1656
* #1657
* #1660
* #1663
* #1666
* #1667
* #1668
* #1670
* #1671
* #1673
* #1674
* #1675
* #1676
* #1677
* #1681
* #1682
* #1683
* #1684
* #1687
* #1688
* #1689
* #1690
* #1691
* #1692
* #1693
* #1694
* #1695
* #1696
* #1698
* #1699
* #1702
* #1703
* #1704
* #1705
* #1707
* #1708
* #1709
* #1710
* #1711
* #1712
* #1713
* #1714
* #1715
* #1716
* #1717
* #1718
* #1720
* #1721
* #1722
* #1723
* #1727
* #1728
* #1729
* #1731
* #1732
* #1733
* #1734
* #1735
* #1736
* #1737
* #1740
* #1741
* #1743
* #1744
* #1745
* #1746
* #1751
* #1753
* #1754
* #1755
* #1757
* #1762
* #1763
* #1764
* #1765
* #1766
* #1767
* #1769
* #1771
* #1772
* #1773
* #1774
* #1777
* #1778
* #1785
* #1786
* #1787
* #1788
* #1789
* #1790
* #1791
* #1792
* #1793
* #1794
* #1795
* #1796
* #1797
* #1798
* #1799
* #1800
* #1802
* #1803
* #1804
* #1805
* #1807
* #1808
* #1809
* #1810
* #1811
* #1812
* #1814
* #1815
* #1821
* #1822
* #1823
* #1824
* #1825
* #1826
* #1827
* #1828
* #1830
* #1831
* #1832
* #1833
* #1834
* #1835
* #1836
* #1837
* #1838
* #1839
* #1840
* #1841
* #1842
* #1843
* #1844
* #1845
* #1847
* #1848
* #1849
* #1850
* #1851
* #1854
* #1855
* #1856
* #1857
* #1860
* #1861
* #1863
* #1864
* #1865
* #1866
* #1867
* #1871
* #1872
* #1873
* #1875
* #1876
* #1877
* #1878
* #1880
* #1881
* #1882
* #1883
* #1884
* #1885
* #1886
* #1888
* #1889
* #1890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants