Skip to content

Commit

Permalink
Merge pull request #25 from agiledigital-labs/dependabot/npm_and_yarn…
Browse files Browse the repository at this point in the history
…/types/express-4.17.9

chore(deps-dev): Bump @types/express from 4.17.8 to 4.17.9
  • Loading branch information
shouvSarker authored Nov 20, 2020
2 parents fbc510e + 644f725 commit 54faace
Show file tree
Hide file tree
Showing 3 changed files with 269 additions and 224 deletions.
8 changes: 7 additions & 1 deletion app/control-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,13 @@ export const control = async (port: number, config: MocksType) => {
res.status(204).end();
});

return new Promise((resolve, _reject) => {
/**
* Optionality for promise resolve callback has been removed.
* resolve() can still be called without an argument if type void is specified when creating new promise.
* For more information, see https://github.com/microsoft/TypeScript/pull/39817
* This change was made to resolve updating @types/express to 4.17.9.
*/
await new Promise<void>((resolve, _reject) => {
startApp(port, app, () => {
console.log(`api mock server running on [${port}].`);
resolve();
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"devDependencies": {
"@semantic-release/commit-analyzer": "^8.0.1",
"@semantic-release/git": "^9.0.0",
"@types/express": "^4.17.8",
"@types/express": "^4.17.9",
"@types/express-mung": "^0.5.2",
"@types/jest": "^26.0.15",
"@types/uuid": "^8.3.0",
Expand Down
Loading

0 comments on commit 54faace

Please sign in to comment.