Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): Bump @types/express from 4.17.8 to 4.17.9 #25

Merged
merged 4 commits into from
Nov 20, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 11, 2020

Bumps @types/express from 4.17.8 to 4.17.9.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 11, 2020
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/types/express-4.17.9 branch from bffff2f to e4c46a1 Compare November 17, 2020 10:14
@shouvSarker
Copy link
Contributor

shouvSarker commented Nov 20, 2020

Updating types/express broke typescript build, see microsoft/TypeScript#39817.

Had to set void type for new promise. Tests are passing now. Requesting review for a sanity check.

@shouvSarker shouvSarker requested a review from robinMcA November 20, 2020 06:07
Copy link
Member

@SamMurphyDev SamMurphyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for leaving that comment for the reason to need to explicitly define that type 👍

app/control-api.ts Outdated Show resolved Hide resolved
Copy link
Member

@SamMurphyDev SamMurphyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shouvSarker shouvSarker merged commit 54faace into master Nov 20, 2020
@shouvSarker shouvSarker deleted the dependabot/npm_and_yarn/types/express-4.17.9 branch November 20, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants