Skip to content

Commit

Permalink
[stable/sonatype-nexus] Reorder host names in ingress (helm#11513)
Browse files Browse the repository at this point in the history
Make `nexusHttpHost` the first in the list of TLS hosts.
This is to ensure that the common name (as displayed in the browser)
in the generated Let's Encrypt TLS certificate is the `nexusHttpHost`,
while `nexusDockerHost` is added to subject alternative names.

Signed-off-by: Sergei Ivanov <[email protected]>
  • Loading branch information
sergei-ivanov authored and k8s-ci-robot committed Feb 20, 2019
1 parent fd2055e commit 5823251
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion stable/sonatype-nexus/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: sonatype-nexus
version: 1.16.1
version: 1.16.2
appVersion: 3.15.2-01
description: Sonatype Nexus is an open source repository manager
keywords:
Expand Down
6 changes: 3 additions & 3 deletions stable/sonatype-nexus/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ metadata:
{{- end }}
spec:
rules:
- host: {{ .Values.nexusProxy.env.nexusDockerHost }}
- host: {{ .Values.nexusProxy.env.nexusHttpHost }}
http:
paths:
- backend:
serviceName: {{ template "nexus.fullname" . }}
servicePort: {{ .Values.nexusProxy.port }}
path: {{ .Values.ingress.path }}
- host: {{ .Values.nexusProxy.env.nexusHttpHost }}
- host: {{ .Values.nexusProxy.env.nexusDockerHost }}
http:
paths:
- backend:
Expand All @@ -28,8 +28,8 @@ spec:
{{- if .Values.ingress.tls.enabled }}
tls:
- hosts:
- {{ .Values.nexusProxy.env.nexusDockerHost }}
- {{ .Values.nexusProxy.env.nexusHttpHost }}
- {{ .Values.nexusProxy.env.nexusDockerHost }}
{{- if .Values.ingress.tls.secretName }}
secretName: {{ .Values.ingress.tls.secretName | quote }}
{{- end }}
Expand Down

0 comments on commit 5823251

Please sign in to comment.