Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the app's container in aiidalab home #985

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Dec 17, 2024

This PR uses new CSS classes introduced in aiidalab/aiidalab-home#190 to redesign the app's container in the home app.

Resolves #983

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.54%. Comparing base (9522470) to head (15d1d93).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
- Coverage   68.55%   68.54%   -0.02%     
==========================================
  Files         111      111              
  Lines        6307     6307              
==========================================
- Hits         4324     4323       -1     
- Misses       1983     1984       +1     
Flag Coverage Δ
python-3.11 68.54% <ø> (-0.02%) ⬇️
python-3.9 68.56% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikibonacci mikibonacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @edan-bainglass!

@edan-bainglass edan-bainglass force-pushed the home-app-widget-redesign branch from 71475ad to 15d1d93 Compare December 18, 2024 12:56
@edan-bainglass edan-bainglass merged commit dcb7c93 into aiidalab:main Dec 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve home page of the app (in the main list of apps)
2 participants