Skip to content

Commit

Permalink
Merge pull request #511 from Insoleet/master
Browse files Browse the repository at this point in the history
Fix host detection raising unclear exception
asvetlov committed Sep 17, 2015

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
2 parents 5257fae + 5b0065c commit dd4062e
Showing 2 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions aiohttp/client_reqrep.py
Original file line number Diff line number Diff line change
@@ -112,6 +112,9 @@ def update_host(self, url):

# get host/port
host = url_parsed.hostname
if not host:
raise ValueError('Host could not be detected.')

try:
port = url_parsed.port
except ValueError:
5 changes: 5 additions & 0 deletions tests/test_client_request.py
Original file line number Diff line number Diff line change
@@ -96,6 +96,11 @@ def test_host_port_err(self):
ValueError, ClientRequest, 'get', 'http://python.org:123e/',
loop=self.loop)

def test_hostname_err(self):
self.assertRaises(
ValueError, ClientRequest, 'get', 'http://:8080/',
loop=self.loop)

def test_host_header(self):
req = ClientRequest('get', 'http://python.org/', loop=self.loop)
self.assertEqual(req.headers['HOST'], 'python.org')

0 comments on commit dd4062e

Please sign in to comment.