Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monetary update #852

Merged
merged 4 commits into from
Mar 25, 2019
Merged

Monetary update #852

merged 4 commits into from
Mar 25, 2019

Conversation

AionJayT
Copy link
Collaborator

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

Fixes Issue # .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT mentioned this pull request Mar 20, 2019
12 tasks
@AionJayT AionJayT added bug Something isn't working wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions labels Mar 20, 2019
@AionJayT AionJayT modified the milestones: 0.4.0, 0.3.3 Mar 20, 2019
@AionJayT AionJayT force-pushed the monetaryUpdate branch 2 times, most recently from 5be1be1 to 2f83196 Compare March 20, 2019 19:00
@AionJayT AionJayT changed the base branch from master-pre-merge to 0.4 March 20, 2019 19:07
@qoire
Copy link
Contributor

qoire commented Mar 22, 2019

LGTM

@AionJayT AionJayT removed the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Mar 22, 2019
@AionJayT AionJayT merged commit add2c9f into 0.4 Mar 25, 2019
@AionJayT AionJayT deleted the monetaryUpdate branch March 26, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants