Introducing monetary policy update #849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AionJayT
added
bug
Python dependencies
DockerAutomation Jenkinsfile bugfixes: typos in filename and image name
- These consensus tests anticipate the next commit, which seeks to move "pure balance transfers" to the Avm instead of the Fvm. - These are also just going to be valuable to have going forward.
- A pure balance transfer is just a balance transfer to a non-contract address. Formerly these were handled by the Fvm, now they are handled by the Avm.
Avm now handles "pure" balance transfers
AionJayT
changed the title
- corrected address generation inside AionCapabilities.java - expanded repository interface with check for VM deploy code - updated the VM specs with two supported VM codes for contract deploy - removed prefix checks from tests - expanded tests to ensure the receipt output matches the contract address
…on type - using the local version of the vm_api since more changes are expected
Removing the AVM prefix
…ssue of the AVM transaction
|
Whoa! This PR is big, I will be reviewing the MonetaryCalculator and MonetaryCalculatorTest classes. Edit: Savage has already reviewed the changes |
qoire
suggested changes
Mar 20, 2019
|
close this PR, reopen in #852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.
Description
Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.
Fixes Issue # .
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.
Verification
Insert x into the following checkboxes to confirm (eg. [x]):