Merge pull request #491 from airbrake/faster-dumping-for-performance-…

…stats

stat: define custom #inspect

CHANGELOG.md

@@ -5,6 +5,8 @@ Airbrake Ruby Changelog
 
 * Improved performance of `PerformanceNotifier` (sic!)
   ([#490](https://github.com/airbrake/airbrake-ruby/pull/490))
+* Improved performance of `Airbrake::Stat` when logging (or inspecting)
+  ([#491](https://github.com/airbrake/airbrake-ruby/pull/491))
 
 ### [v4.5.0][v4.5.0] (June 25, 2019)
 

lib/airbrake-ruby/stat.rb

@@ -1,5 +1,6 @@
 require 'base64'
 
+# rubocop:disable Metrics/BlockLength
 module Airbrake
   # Stat is a data structure that allows accumulating performance data (route
   # performance, SQL query performance and such). It's powered by TDigests.
@@ -58,5 +59,15 @@ def increment_ms(ms)
 
       tdigest.push(ms)
     end
+
+    # We define custom inspect so that we weed out uninformative TDigest, which
+    # is also very slow to dump when we log Airbrake::Stat.
+    #
+    # @return [String]
+    def inspect
+      "#<struct Airbrake::Stat count=#{count}, sum=#{sum}, sumsq=#{sumsq}>"
+    end
+    alias_method :pretty_print, :inspect
   end
 end
+# rubocop:enable Metrics/BlockLength

spec/stat_spec.rb

@@ -30,4 +30,18 @@
       expect(subject.tdigest.size).to eq(1)
     end
   end
+
+  describe "#inspect" do
+    it "provides custom inspect output" do
+      expect(subject.inspect).to eq(
+        '#<struct Airbrake::Stat count=0, sum=0.0, sumsq=0.0>'
+      )
+    end
+  end
+
+  describe "#pretty_print" do
+    it "is an alias of #inspect" do
+      expect(subject.method(:pretty_print)).to eql(subject.method(:inspect))
+    end
+  end
 end