stat: define custom #inspect #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully fixes #488 (Increase in CPU usage when performance_stats = true) I noticed that dumping TDigest is very slow. Here's performance payload with TDigests: ``` Warming up -------------------------------------- 1.553k i/100ms Calculating ------------------------------------- 15.906k (± 3.0%) i/s - 80.756k in 5.082704s ``` And here's the same payload but without TDigests. ``` Warming up -------------------------------------- 4.443k i/100ms Calculating ------------------------------------- 45.498k (± 1.8%) i/s - 231.036k in 5.079495s ``` It makes sense to not dump TDigests because it's mostly clutter and it makes performance much worse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #488 (Increase in CPU usage when performance_stats = true)
I noticed that dumping TDigest is very slow. Here's performance payload with
TDigests:
And here's the same payload but without TDigests.
It makes sense to not dump TDigests because it's mostly clutter and it makes
performance much worse.