Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a default for root_directory #167

Closed
grosser opened this issue Feb 17, 2017 · 2 comments · Fixed by #171
Closed

use a default for root_directory #167

grosser opened this issue Feb 17, 2017 · 2 comments · Fixed by #171
Labels
Feature

Comments

@grosser
Copy link
Contributor

grosser commented Feb 17, 2017

something sensible would be nice to avoid having to always set it ...

(defined?(Bundler) && Bundler.root.to_s) || File.expand_path(Dir.pwd)
@kyrylo
Copy link
Contributor

kyrylo commented Feb 20, 2017

I don't see why not. Would you mind sending a PR?

P.S. Bundler.root.to_s can be Bundler.root because we accept Pathname's.

@kyrylo kyrylo added the Feature label Feb 20, 2017
@grosser grosser mentioned this issue Feb 20, 2017
Merged
@grosser
Copy link
Contributor Author

grosser commented Feb 20, 2017

done: #171

@grosser grosser closed this as completed Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set a default root_directory so source code highlighting works out of… grosser/airbrake-ruby
2 participants
@grosser @kyrylo