set a default root_directory so source code highlighting works out of… #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy to merge this when the Rubocop offence is fixed. |
grosser
force-pushed
the
grosser/root
branch
from
1eec183 to
b54b3ad
Compare
|
thx for pinging ... did not watch CI :D |
|
Thanks. Although Circle is stuck, I can see some failing tests :( |
grosser
force-pushed
the
grosser/root
branch
from
b54b3ad to
0b43f2c
Compare
|
all good! |
grosser
commented
Feb 22, 2017
| @@ -167,11 +167,11 @@ | |||
| filter_chain = notifier.instance_variable_get(:@filter_chain) | |||
| filters = filter_chain.instance_variable_get(:@filters) | |||
|
|
|||
| expect(filters.size).to eq(2) | |||
| expect(filters.size).to eq(3) | |||
There was a problem hiding this comment.
idk why this happened ...
There was a problem hiding this comment.
might be that a filter is added when root_directory exists
There was a problem hiding this comment.
That's expected
airbrake-ruby/lib/airbrake-ruby/filter_chain.rb
Lines 56 to 57 in 43f780b
kyrylo
added a commit
that referenced
this pull request
Feb 22, 2017
kyrylo
added a commit
that referenced
this pull request
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the box
fixes #167