Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airbrake performance changes are filling logs with deprecation messages #532

Closed
wflanagan opened this issue Dec 27, 2019 · 4 comments · Fixed by airbrake/airbrake#1060
Closed

Airbrake performance changes are filling logs with deprecation messages #532

wflanagan opened this issue Dec 27, 2019 · 4 comments · Fixed by airbrake/airbrake#1060
Labels
Question

Comments

@wflanagan
Copy link

In our logs since upgrading to 4.11.1 our logs are FULL (literally 2 lines per each controller load) of this:

/root/.rbenv/versions/2.6.4/lib/ruby/gems/2.6.0/gems/airbrake-ruby-4.11.1/lib/airbrake-ruby.rb:369: warning: :start_time and :end_time are deprecated. Use :timing & :time instead
/root/.rbenv/versions/2.6.4/lib/ruby/gems/2.6.0/gems/airbrake-ruby-4.11.1/lib/airbrake-ruby.rb:451: warning: :start_time and :end_time are deprecated. Use :timing & :time instead

We do a lot of work to make sure our logs are clean and relevant. This deprecation warning is literally 66% of our logs at this point (as we use Lograge and each controller's log is 1 line). And, it's not 1 time, it's literally on every request.
@bcm
Copy link

bcm commented Jan 4, 2020

And it's costing me money, as my Papertrail log volume has gone through the roof.

@wflanagan
Copy link
Author

Mine as well. We keep running out, and then we have no logging for our app.

@kyrylo
Copy link
Contributor

kyrylo commented Jan 6, 2020

Sorry about this. I would recommend locking airbrake-ruby to the previous version for now, until I update the airbrake gem to the new API. I will ping you here once this is done & released.

@kyrylo kyrylo added the Question label Jan 6, 2020
kyrylo added a commit to airbrake/airbrake that referenced this issue Jan 8, 2020
@kyrylo
Fix deprecation warnings about :start_time & :end_time
f60ce03 
Resolves airbrake/airbrake-ruby#532
(Airbrake performance changes are filling logs with deprecation messages)

This was inroduced by airbrake/airbrake-ruby#526
We can now pass `event.duration`, so there's no need to calculate it again. This
is more accurate as well since we pass monotonic time instead of realtime.
@kyrylo kyrylo mentioned this issue Jan 8, 2020
Merged
kyrylo added a commit to airbrake/airbrake that referenced this issue Jan 8, 2020
@kyrylo
Fix deprecation warnings about :start_time & :end_time
482cd49 
Resolves airbrake/airbrake-ruby#532
(Airbrake performance changes are filling logs with deprecation messages)

This was inroduced by airbrake/airbrake-ruby#526
We can now pass `event.duration`, so there's no need to calculate it again. This
is more accurate as well since we pass monotonic time instead of realtime.
@kyrylo
Copy link
Contributor

kyrylo commented Jan 8, 2020

I just released airbrake v10.0.0. Please upgrade to it and the warning will go away. Apologies again for the inconvenience 😔

@MathieuDerelle MathieuDerelle mentioned this issue Feb 14, 2020
Closed
FGoessler added a commit to blinkist/airbrake-scrubber that referenced this issue May 25, 2020
@FGoessler
Support airbrake 10
6c3afd3 
Required to remove deprecation warnings that spam our logs. See airbrake/airbrake-ruby#532.
@FGoessler FGoessler mentioned this issue May 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecation warnings about :start_time & :end_time airbrake/airbrake
3 participants
@bcm @wflanagan @kyrylo