Deprecate :{start,end}_time, add :timing instead #526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few reasons for this change:
We use realtime to measure performance for the
:total
stat. This is nogood, especially since we use monotonic time for other groups. It is
inconsitent and confusing
New functionality requires a better API. Specifically, we want to be able to
send timing of a certain job. To achieve that we wrap the job in a benchmark
measure
call. The problem is that our API doesn't make it easy to sendalready calculated timing.
start_time
makes the user code very clunky andconfusing
Before:
After: