-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve jruby detection #408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weird that our CI didn't catch that. The line you're fixing was my 2nd attempt after the CI failed, so I thought we were good. Either way, thanks! |
kyrylo
added a commit
that referenced
this pull request
Feb 11, 2019
The current approach doesn't work with JRuby. The patch that aimed to fix the issue didn't actually work (duh): #408 The problem is that I run `gem build *.gemspec` using CRuby, so the JRuby check inside the gemspec always has the same outcome. This change builds gems properly, with `rake gems`.
kyrylo
added a commit
that referenced
this pull request
Feb 11, 2019
The current approach doesn't work with JRuby. The patch that aimed to fix the issue didn't actually work (duh): #408 The problem is that I run `gem build *.gemspec` using CRuby, so the JRuby check inside the gemspec always has the same outcome. This change builds gems properly, with `rake gems`.
kyrylo
added a commit
that referenced
this pull request
Feb 11, 2019
The current approach doesn't work with JRuby. The patch that aimed to fix the issue didn't actually work (duh): #408 The problem is that I run `gem build *.gemspec` using CRuby, so the JRuby check inside the gemspec always has the same outcome. This change builds gems properly, with `rake gems`.
kyrylo
added a commit
that referenced
this pull request
Feb 11, 2019
The current approach doesn't work with JRuby. The patch that aimed to fix the issue didn't actually work (duh): #408 The problem is that I run `gem build *.gemspec` using CRuby, so the JRuby check inside the gemspec always has the same outcome. This change builds gems properly, with `rake gems`.
kyrylo
added a commit
that referenced
this pull request
Feb 11, 2019
The current approach doesn't work with JRuby. The patch that aimed to fix the issue didn't actually work (duh): #408 The problem is that I run `gem build *.gemspec` using CRuby, so the JRuby check inside the gemspec always has the same outcome. This change builds gems properly, with `rake gems`.
kyrylo
added a commit
that referenced
this pull request
Feb 12, 2019
The current approach doesn't work with JRuby. The patch that aimed to fix the issue didn't actually work (duh): #408 The problem is that I run `gem build *.gemspec` using CRuby, so the JRuby check inside the gemspec always has the same outcome. This change builds gems properly, with `rake gems`.
kyrylo
added a commit
that referenced
this pull request
Feb 12, 2019
The current approach doesn't work with JRuby. The patch that aimed to fix the issue didn't actually work (duh): #408 The problem is that I run `gem build *.gemspec` using CRuby, so the JRuby check inside the gemspec always has the same outcome. This change builds gems properly, with `rake gems`.
kyrylo
added a commit
that referenced
this pull request
Feb 12, 2019
The current approach doesn't work with JRuby. The patch that aimed to fix the issue didn't actually work (duh): #408 The problem is that I run `gem build *.gemspec` using CRuby, so the JRuby check inside the gemspec always has the same outcome. This change builds gems properly, with `rake gems`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing an issue with 3.2.0 on jruby, my builds are failing because bundler is attempting to install the ruby version of rbtree3, not the jruby version.
I think the current method of detecting jruby doesn't work in all cases, for example when using rvm on travis.
You can see that its trying to use
rbtree3
, notrbtree-jruby
, despite being on jruby.