Build this gem on JRuby properly #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
gem-building
branch
6 times, most recently
from
00f4857 to
8e92cd6
Compare
The current approach doesn't work with JRuby. The patch that aimed to fix the issue didn't actually work (duh): #408 The problem is that I run `gem build *.gemspec` using CRuby, so the JRuby check inside the gemspec always has the same outcome. This change builds gems properly, with `rake gems`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach doesn't work with JRuby. The patch that aimed to fix the
issue didn't actually work (duh):
#408
The problem is that I run
gem build *.gemspecusing CRuby, so the JRuby checkinside the gemspec always has the same outcome. This change builds gems
properly, with
rake gems.