airbrake-ruby: make sure optional filters are loaded #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #460 (blacklist_keys config doesn't work) The problem was that we never reconfigured already instantiated notifiers. We always spawn notifiers as soon as the library is required but they get spawned without some of default filters that are supposed to work given certain options such as `blacklist_keys`. The new `#reset` method respawns all notifiers on `#configure`. We have to respawn so the new notifiers pickup the config. We need to spawn without the user config so all the methods are working (e.g. notify returns a rejected promise and such).
kyrylo
force-pushed
the
460-blacklist-filter-fix
branch
from
5a02641 to
9b55860
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460 (blacklist_keys config doesn't work)
The problem was that we never reconfigured already instantiated notifiers. We
always spawn notifiers as soon as the library is required but they get spawned
without some of default filters that are supposed to work given certain options
such as
blacklist_keys.The new
#resetmethod respawns all notifiers on#configure. We have torespawn so the new notifiers pickup the config. We need to spawn without the
user config so all the methods are working (e.g. notify returns a rejected
promise and such).