Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Start depending on airbrake-ruby 4.2.2? #941

Closed
francois-belle opened this issue Mar 28, 2019 · 3 comments
Closed

[REQUEST] Start depending on airbrake-ruby 4.2.2? #941

francois-belle opened this issue Mar 28, 2019 · 3 comments

Comments

@francois-belle
Copy link

  • Airbrake version: 8.3.2
  • Ruby version: 2.5.3
  • Framework name & version: Rails 5.2.2

Airbrake config

Airbrake.configure do |c|
  c.project_key         = ENV['AIRBRAKE_PROJECT_KEY']
  c.project_id          = ENV['AIRBRAKE_PROJECT_ID']
  c.host                = ENV['AIRBRAKE_HOST']
  c.root_directory = Rails.root
  c.logger = Rails.logger
  c.environment = Rails.env
  c.ignore_environments = %w[test development]
  c.blacklist_keys = [/password/i, /authorization/i]
end

Description

Hey guys, first of all, thank you for this amazing gem!

I did the setup and tried sending some test notifications.
The problem is that my blacklist_keys are not taken into account and every password appears in clear in the errors reporting tool (I'm using Errbit).
I think it's a known issue that was fixed in this PR in airbrake-ruby dependency.
This fix was released in airbrake-ruby 4.2.2 but aibrake depends on airbrake-ruby 4.1.

Do you think it's possible to move on to the latest version of airbrake-ruby?

Any help would be greatly appreciated.
François

@kyrylo
Copy link
Contributor

kyrylo commented Mar 28, 2019

Hi, yeah, that's the plan. Thanks for pinging, I actually forgot that this gem was locked to 4.1. I'll release a new version today.

@kyrylo
Copy link
Contributor

kyrylo commented Mar 28, 2019

Small update. There are some complexities with upgrading, so I need a bit more time. Sorry for the false information.

kyrylo added a commit that referenced this issue Mar 29, 2019
Fixes #941 ([REQUEST] Start depending on airbrake-ruby 4.2.2?)
@francois-belle
Copy link
Author

francois-belle commented Apr 1, 2019

Thanks for the update @kyrylo 🙏
EDIT: Tested and it works 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants