-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Jira: changed cursor field from created to updated #5426
🐛 Source Jira: changed cursor field from created to updated #5426
Conversation
…s.started to fields.updated, update IssuesWorklogs slicing
/test connector=source-jira
|
@@ -7455,10 +7455,10 @@ | |||
}, | |||
"supported_sync_modes": ["incremental"], | |||
"source_defined_cursor": true, | |||
"default_cursor_field": ["created"] | |||
"default_cursor_field": ["fields", "updated"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont sure about this change.
Previously issues.fields where a field containing additionalproperties. Yes, updated exists there.
It were stored as JSON column, and it will be possibly returned to additionalproperties without details (like it was before), to avoid data missing and db structure change. We'll discuss this tomorrow
@Phlair would you be able to review this one? |
current_stream_state = current_stream_state.get(self.cursor_field) | ||
if current_stream_state: | ||
return {self.cursor_field: str(max(latest_record_date, pendulum.parse(current_stream_state)))} | ||
issue_id = latest_record.get("issueId") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this changing? we shouldn't store separate state for each issue, this can get massive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's just make this stream full refresh for now
/test connector=source-jira
|
/test connector=source-jira
|
/test connector=source-jira
|
/publish connector=connectors/source-jira
|
What
Changed cursor field for Issues stream from created to updated JQL field. Updated cursor filed in schema for Issues stream. Improved slicing and cursor field for IssuesWorklogs stream.
Closes #4505
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
docs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md