Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Jira: changed cursor field from created to updated #5426

Merged
merged 6 commits into from
Sep 2, 2021
Merged

🐛 Source Jira: changed cursor field from created to updated #5426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a56a2ac
Source Jira #4505 - change cursor field for Issues streams from field…
vitaliizazmic Aug 13, 2021
316a78e
Source Jira #4505 - reformat
vitaliizazmic Aug 16, 2021
2221a87
Jira #4505 - made issues worklog stream full refresh
vitaliizazmic Aug 31, 2021
805bdd7
Jira #4505 - reformat
vitaliizazmic Aug 31, 2021
ec8e3fe
Merge branch 'master' into vitalii/4505_jira_use_update_for_cursor_field
vitaliizazmic Sep 1, 2021
1015702
Jira #4505 - bump version and updating documentation
vitaliizazmic Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/resources/config/STANDARD_SOURCE_DEFINITION/68e63de2-bb83-4c7e-93fa-a8a9051e3993.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"sourceDefinitionId": "68e63de2-bb83-4c7e-93fa-a8a9051e3993",
"name": "Jira",
"dockerRepository": "airbyte/source-jira",
"dockerImageTag": "0.2.8",
"dockerImageTag": "0.2.9",
"documentationUrl": "https://docs.airbyte.io/integrations/sources/jira",
"icon": "jira.svg"
}
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@
- sourceDefinitionId: 68e63de2-bb83-4c7e-93fa-a8a9051e3993
name: Jira
dockerRepository: airbyte/source-jira
dockerImageTag: 0.2.8
dockerImageTag: 0.2.9
documentationUrl: https://docs.airbyte.io/integrations/sources/jira
icon: jira.svg
- sourceDefinitionId: 12928b32-bf0a-4f1e-964f-07e12e37153a
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-jira/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.8
LABEL io.airbyte.version=0.2.9
LABEL io.airbyte.name=airbyte/source-jira
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-jira/integration_tests/abnormal_state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"created": "2121-02-14T22:01:22.313Z"
},
"issue_worklogs": {
"startedAfter": "2121-04-14T11:30:22.313Z"
"started": "2121-04-14T11:30:22.313Z"
}
}
14 changes: 6 additions & 8 deletions airbyte-integrations/connectors/source-jira/integration_tests/full_configured_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7455,10 +7455,10 @@
},
"supported_sync_modes": ["incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["created"]
"default_cursor_field": ["fields", "updated"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont sure about this change.
Previously issues.fields where a field containing additionalproperties. Yes, updated exists there.
It were stored as JSON column, and it will be possibly returned to additionalproperties without details (like it was before), to avoid data missing and db structure change. We'll discuss this tomorrow

},
"sync_mode": "incremental",
"cursor_field": ["created"],
"cursor_field": ["fields", "updated"],
"destination_sync_mode": "append"
},
{
Expand Down Expand Up @@ -9532,13 +9532,11 @@
"additionalProperties": true,
"description": "Details of a worklog."
},
"supported_sync_modes": ["incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["startedAfter"]
"supported_sync_modes": ["full_refresh"],
"source_defined_cursor": false
},
"sync_mode": "incremental",
"cursor_field": ["startedAfter"],
"destination_sync_mode": "append"
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite"
},
{
"stream": {
Expand Down
14 changes: 6 additions & 8 deletions airbyte-integrations/connectors/source-jira/integration_tests/inc_configured_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,21 @@
"json_schema": {},
"supported_sync_modes": ["incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["created"]
"default_cursor_field": ["fields", "updated"]
},
"sync_mode": "incremental",
"cursor_field": ["created"],
"cursor_field": ["fields", "updated"],
"destination_sync_mode": "append"
},
{
"stream": {
"name": "issue_worklogs",
"json_schema": {},
"supported_sync_modes": ["incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["startedAfter"]
"supported_sync_modes": ["full_refresh"],
"source_defined_cursor": false
},
"sync_mode": "incremental",
"cursor_field": ["startedAfter"],
"destination_sync_mode": "append"
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite"
}
]
}
10 changes: 4 additions & 6 deletions ...egrations/connectors/source-jira/integration_tests/issue_worklogs_configured_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,11 @@
"stream": {
"name": "issue_worklogs",
"json_schema": {},
"supported_sync_modes": ["incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["startedAfter"]
"supported_sync_modes": ["full_refresh"],
"source_defined_cursor": false
},
"sync_mode": "incremental",
"cursor_field": ["startedAfter"],
"destination_sync_mode": "append"
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite"
}
]
}
10 changes: 10 additions & 0 deletions airbyte-integrations/connectors/source-jira/integration_tests/sample_state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"issues": {
"updated": "2021-06-02T22:18:39.882Z"
},
"issue_worklogs": {
"10622": {
"started": "2021-02-14T11:30:22.313Z"
}
}
}
14 changes: 6 additions & 8 deletions airbyte-integrations/connectors/source-jira/sample_files/configured_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7962,10 +7962,10 @@
},
"supported_sync_modes": ["incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["created"]
"default_cursor_field": ["fields", "updated"]
},
"sync_mode": "incremental",
"cursor_field": ["created"],
"cursor_field": ["fields", "updated"],
"destination_sync_mode": "append"
},
{
Expand Down Expand Up @@ -10086,13 +10086,11 @@
"additionalProperties": true,
"description": "Details of a worklog."
},
"supported_sync_modes": ["incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["startedAfter"]
"supported_sync_modes": ["full_refresh"],
"source_defined_cursor": false
},
"sync_mode": "incremental",
"cursor_field": ["startedAfter"],
"destination_sync_mode": "append"
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite"
},
{
"stream": {
Expand Down
14 changes: 6 additions & 8 deletions airbyte-integrations/connectors/source-jira/sample_files/full_configured_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7455,10 +7455,10 @@
},
"supported_sync_modes": ["incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["created"]
"default_cursor_field": ["fields", "updated"]
},
"sync_mode": "incremental",
"cursor_field": ["created"],
"cursor_field": ["fields", "updated"],
"destination_sync_mode": "append"
},
{
Expand Down Expand Up @@ -9532,13 +9532,11 @@
"additionalProperties": true,
"description": "Details of a worklog."
},
"supported_sync_modes": ["incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["startedAfter"]
"supported_sync_modes": ["full_refresh"],
"source_defined_cursor": false
},
"sync_mode": "incremental",
"cursor_field": ["startedAfter"],
"destination_sync_mode": "append"
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite"
},
{
"stream": {
Expand Down
6 changes: 4 additions & 2 deletions airbyte-integrations/connectors/source-jira/sample_files/sample_state.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
{
"issues": {
"created": "2021-02-14T22:01:22.313Z"
"updated": "2021-06-02T22:18:39.882Z"
},
"issue_worklogs": {
"startedAfter": "2021-04-14T11:30:22.313Z"
"10622": {
"started": "2021-02-14T11:30:22.313Z"
}
}
}
Loading