Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utf-8 encoding #14

Closed
ajwalkiewicz opened this issue Nov 23, 2022 · 0 comments · Fixed by #15
Closed

Add utf-8 encoding #14

ajwalkiewicz opened this issue Nov 23, 2022 · 0 comments · Fixed by #15
Labels
bug Something isn't working

Comments

@ajwalkiewicz
Copy link
Owner

ajwalkiewicz commented Nov 23, 2022 •
edited
Loading

This is most likely the reason why tests on Windows are failing:

See: https://github.com/ajwalkiewicz/cochar/actions/runs/3535553085/jobs/5933763251

As a reference: mwouts/jupytext#770
@ajwalkiewicz ajwalkiewicz added the bug Something isn't working label Nov 23, 2022
@ajwalkiewicz ajwalkiewicz moved this to Todo in cochar Nov 23, 2022
@ajwalkiewicz ajwalkiewicz moved this from Todo to In Progress in cochar Nov 25, 2022
ajwalkiewicz added a commit that referenced this issue Nov 25, 2022
@ajwalkiewicz
Add utf-8 encoding when open files, #14
6a2e4a2 
This should fix the issue with broken tests
on Windows.
@ajwalkiewicz ajwalkiewicz linked a pull request Nov 25, 2022 that will close this issue
Add utf-8 encoding when open files, #14 #15
Merged
ajwalkiewicz added a commit that referenced this issue Nov 25, 2022
@ajwalkiewicz
Merge pull request #15 from ajwalkiewicz/14-add-utf-8-encoding
6192928 
Add utf-8 encoding when open files, #14
Repository owner moved this from In Progress to Done in cochar Nov 25, 2022
@ajwalkiewicz ajwalkiewicz mentioned this issue Nov 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
cochar
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add utf-8 encoding when open files, #14 ajwalkiewicz/cochar
1 participant
@ajwalkiewicz