-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(NbDialogService): support passing values to input/model signals
This makes an exception for input and model signals in the DialogConfig context, so the typehint will show as the type of the signal's value, but internally it will create a signal with the passed value. Technically these will just be readonly signals instead of input or model signals, but since components used as a dialog do not support regular outputs anyway, it should not matter. When used in a regular context the input signal will not be overwritten and work as usual. closes #3256 (I would not classify this as a bug but a missing feature instead)
- Loading branch information
1 parent
6b53c71
commit cd6048d
Showing
2 changed files
with
21 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters